Re: [htdig-dev] Gilles' patch for configuration

[Gabriele B. <an...@ti...>]

Hi Gilles,

At 22.10 09/06/2004, Gilles Detillieux wrote:
>Just curious, but why did you need to manually apply my patch?  Did it
>not work with the patch command?  The manual changes to conf_lexer.lxx
>were OK, despite lots of changes to the indentation which now make it
>harder to read (remember standard tab stops are 8 spaces), but you missed
>one of my changes to conf_parser.yxx, which is likely to break things.

No, it did not work. I had all the changes rejected. I tried to apply it 
against the latest CVS code. That's probably why I stuffed things up. 
However, I am sorry about the indentation problem, I had 4 spaces set.

>It would be a shame to release yet another beta release and still not
>have these problems fixed!  Proper error handling has been lacking for
>a long time, and many users have been confused by the config parser's
>cryptic error messages.  This will at least tell them what file to look
>at, and the proper line number when using includes.  The problem with
>files then end without a newline has caught many people too.

OK. I perfectly agree with you. That's why I asked people's opinion and I 
rely on yours very much.

>this patch to go into b6, but it would be a good idea if a few other
>developers tested it first, as I asked back in April.  All I can say is
>it works for me (but I tested it using flex 2.5.4a, and only on RH 9).

You are right. I did not have a chance to try it before. However, tomorrow 
I will regenerate the conf_parser.cxx file and commit the changes, and 
prepare the new release tarball. If everything is fine, I will release 
3.2.0b6 on friday morning Central Europe Time. Sounds good?

Ciao and thanks,
-Gabriele
--
Gabriele Bartolini: Web Programmer, ht://Dig & IWA/HWG Member, ht://Check 
maintainer
Current Location: Prato, Toscana, Italia
an...@ti... | http://www.prato.linux.it/~gbartolini | ICQ#129221447
 > "Leave every hope, ye who enter!", Dante Alighieri, Divine Comedy, The 
Inferno