Re: [htdig-dev] 3.2.0b5 Testing

[Jim C. <li...@yg...>]

On Nov 12, 2003, at 3:28 PM, Gilles Detillieux wrote:

> According to Jim Cole:
>> I did come across one minor bug in Display.cc involving start_ellipses
>> and end_ellipses; but I think that it only manifests itself when
>> max_excerpts is greater than one (a non-default setting). I will post 
>> a
>> bug report later this week.
>
> I think I see the cause of this bug.  In Display::buildExcerpts() it
> mistakenly uses config->Value() instead of config->Find() to get the
> string from the start_ellipses and end_ellipses attributes.  This code 
> is
> only used if max_excerpts is not 1 and the search word(s) is(are) 
> found.
> So did the ellipses simply not show up, or did a 0 appear in their 
> place?

Your diagnosis is correct. I came to the same conclusion, and changing 
from Value to Find did in fact solve the problem. Prior to the change a 
0 appeared in place of the ellipses. I was just holding off submitting 
an official bug report until I had a chance to look at the 3.1.x code 
and see what changed. I just took a quick look and it appears that at 
some point there was a move away from using operator[] to access the 
start_ and end_ellipses settings, at which time Value was substituted.

Jim