Re: [htdig-dev] htsearch 3.2 rejects records with modtime of 0?

[Gilles D. <gr...@sc...>]

According to Lachlan Andrew:
> Greetings,
> 
> I've applied a better patch.  The default for  startyear  is empty, 
> and it is documented that *if* a start/end date is specified then it 
> defaults to 1970.
> 
> Gilles, could you please verify that this fixes the bug, and close the 
> report?
...
> On Thu, 23 Oct 2003 00:05, Lachlan Andrew wrote:
> > The three fixes I can think of are:
> >
> > 1. Set the (hard-coded) default value of  startday  in
> >    htsearch/Display.cc to 0 instead of 1. I'm not sure if this
> >    would work, and it may break other things.
> > 2. Leave  startyear  empty in defaults.cc and manually hack
> >    attrs.hml.
> > 3. Leave  startyear  undocumented.

Yes, I think keeping all of these empty by default is the best approach,
and the one most like 3.1.6 uses.  I think 3.1.6 with patches has a solid
implementation of this, so I'll compare the 2 Display codes to see what
discrepancies I find, and try to figure if these are warranted or not.
I see no reason to go with option 2 or 3 above.

However, I haven't seen your patch, nor has it come through in the CVS
yet if you committed it.  The current htcommon/defaults.cc still has a
default of 1970.  Can I see the fix for this so I can give it a try?
It's not attached to the bug report you filed.

Thanks.

-- 
Gilles R. Detillieux              E-mail: <gr...@sc...>
Spinal Cord Research Centre       WWW:    http://www.scrc.umanitoba.ca/
Dept. Physiology, U. of Manitoba  Winnipeg, MB  R3E 3J7  (Canada)