Re: [htdig-dev] allow_numbers

[Gilles D. <gr...@sc...>]

According to Lachlan Andrew:
> On reflection, I think the behaviour that seems to have been intended 
> is better.  I've filed a bug report (with patch) to implement:
> 
> 1. If allow_numbers is false, words must contain at least one 
> non-digit (2001 not a word, X11 is).
> 2. If allow_numbers is true, digits are equivalent to letters.
> 
> Comments/testing welcome.

I would agree that this is the desirable behaviour, and it is what 3.1.x
implements.  Somewhere in the creation of the WordType class in 3.2, a few
errors were made in porting over the logic of the WordList class in 3.1.
The logical error was in assuming that IsStrictChar() returned false
for digits, when it in fact returns true.  Without actually testing your
patch beyond a visual "walk-through", the new logic appears to be correct.
That the WordType class read allow_numbers as Value rather than Boolean
was just bizarre, but I guess an understandable oversight.

I got thouroughly confused in reading your patch, though, because it is
reversed, with the new code appearing in the first file and the old code
in the second, rather than the other way around.  Taking that into account,
though, the patch seems right to me.  I think it should be committed ASAP.

Speaking of committing to CVS, Neal, what's up with your request to hold off?

According to Neal Richter:
>> Please make the fix but hold off committing it... see
>> previous message, I need to do some busy work on the sourceforge site
>> first.... and we need to wait to hear from anyone with objections ;-)

What was the busy work other than adding bug tracker categories, which
you mentioned in your earlier message?  Are you done and is it OK to
commit now?  I noticed some people have been doing so.

-- 
Gilles R. Detillieux              E-mail: <gr...@sc...>
Spinal Cord Research Centre       WWW:    http://www.scrc.umanitoba.ca/
Dept. Physiology, U. of Manitoba  Winnipeg, MB  R3E 3J7  (Canada)