Re: [htdig-dev] Re: Is this a bug?

[Neal R. <ne...@ri...>]

On Tue, 23 Sep 2003, Lachlan Andrew wrote:

> On Sun, 21 Sep 2003 07:55, Neal Richter wrote:
> > I've got a fix for it.. a couple lines of code in the section that
> > builds the linked list of search results...
>
> That sounds great.  If it checks the search results, I take it that it
> doesn't purge the pages from the database itself.  What is the patch?

  Oops, I misspoke... I don't have a fix for that.. it would take a walk
of the docdb to accomplish a fix!  We would need to tag every document as
'obsolete' and let the spiderer set the values back to 'normal' as they
see the pages.  AFter its finished and htpurge is run, they 'lost' pages
are killed.

  I do have a short fox for another related issue:

  Parser::parse(...)

There is a bug in this for loop:

    for (int i = 0; i < elements->Count(); i++)
    {
    	dm = (DocMatch *) (*elements)[i];
        dm->collection = collection; // back reference

	if (dm->orMatches > 1)
    	    dm->score *= multimatch_factor;

	resultMatches.add(dm);
    }


If the query returned any Documents with a DocState of !=
Reference_normal, they are included in the linked-list of results.  They
are filtered out on display... this is a bit inefficient.  It also screws
up libhtdig results since I don't use display.

Here's the fix, it excludes any document that is not Reference_normal from
the results list.

    for (int i = 0; i < elements->Count(); i++)
    {
           dm = (DocMatch *) (*elements)[i];

           ref = collection->getDocumentRef(dm->GetId());
           if(ref->DocState() == Reference_normal)
           {
                 dm->collection = collection; // back reference

                 if (dm->orMatches > 1)
                    dm->score *= multimatch_factor;

                resultMatches.add(dm);
            }
    }

Thanks

Neal Richter
Knowledgebase Developer
RightNow Technologies, Inc.
Customer Service for Every Web Site
Office: 406-522-1485