[htdig-dev] Adjustable logging patch.

[Brian W. <bw...@st...>]

I am afraid I have dropped off the radar a bit on this one,
so sorry in advance for this coming out of the blue a bit.

Anyway - I was going through the archives and I stumbled
across this post, which I had missed:

>According to J. op den Brouw:
> > It's a nice patch for those who cannot use syslog facilities, but
> > the patch removes the syslog logging feature. It would be nice
> > to select one of them (or have them both) on compile or run time
> > basis.
> >
> > It's also a patch against 3.1.6. It would be nice if there's a
> > patch for 3.2.0b4-xxxx too.
> >
> > Furthermore, I see a flock() call somewhere. AFAIK, different
> > OS-es use different names and parameter lists. Example
> >
> > HP-UX:   int lockf(int fildes, int function, off_t size);
> > Linux 2.2:   int flock(int fd, int operation);
>
>I hadn't noticed when I looked at the patch that it completely removed
>the ability to log to syslog().  That's one more reason to reject
>it for 3.1.x.  I rejected it over concerns about portability, as you
>pointed out.  I don't think it's appropriate for inclusion in 3.1.7
>either for that reason.

Ok.

1) The patch does not remove the ability to do syslog. In my notes
    that go with the patch it says:

>    * logging_file ( Default: none )
>
>      If this is set to "none", then it will log using syslog, otherwise
>      this will be assumed to be the path to the log file


    The whole way it is set up, it uses the existing default
    behaviour if it isn't explicitly activated.

2) If the issue is the portability of flock, would it be
    acceptable if I changed it over to using fcntl?

     (Mr Google threw up the follwoing page which says that "fcntl() is the
      only POSIX-compliant locking mechanism, and is therefore the only
      truly portable lock"

      http://www.erlenstar.demon.co.uk/unix/faq_3.html
      )

3) It should be simple enough to create a patch that works with 3.2.x,
    judging by a quick look at the latest Display.cc in the CVS repository.

I *would* like to get it rolled into 3.1.x if I can. I am
more than willing to make any changes required to make this
happen.

Regs

Brian White


-------------------------
Brian White
Step Two Designs Pty Ltd
Knowledge Management Consultancy, SGML & XML
Phone: +612-93197901
Web:   http://www.steptwo.com.au/
Email: bw...@st...

Content Management Requirements Toolkit
112 CMS requirements, ready to cut-and-paste