Re: [htdig-dev] workaround for mktime/strptime/LC_TIME problems

[Gilles D. <gr...@sc...>]

According to Joe R. Jah:
> On Tue, 27 Nov 2001, Gilles Detillieux wrote:
> > Date: Tue, 27 Nov 2001 15:09:07 -0600 (CST)
> > From: Gilles Detillieux <gr...@sc...>
> > To: Joe R. Jah <jj...@cl...>
> > Cc: Gilles Detillieux <gr...@sc...>,
>      "ht://Dig developers list" <htd...@li...>
> > Subject: Re: [htdig-dev] workaround for mktime/strptime/LC_TIME problems
> > 
> > Like this...  Use "patch -p0 < this-message" in the htdig-3.1.6 source
> > directory from the latest snapshot to use the new date parsing code.
> > I'll probably post it to CVS today or tomorrow.
> 
> It's in the patch archives:
> 
>  ftp://ftp.ccsf.org/htdig-patches/3.1.6/mktime-strptime-LC_TIME.0
> 
> This patch causes ssl.5 to fail.  I modified ssl.5 by removing the bit:
> __________________________htdig/Document.cc_____________________________
> @@ -220,6 +220,7 @@
>           tm.tm_year += 1900;
>         tm.tm_yday = 0; // clear these to prevent problems in strftime()
>         tm.tm_wday = 0;
> +       tm.tm_isdst = -1;
> 
>         if (debug > 2)
>           {
> ________________________________________________________________________
> 
> It seems to be irrelevant after your patch.  The resulting ssl patch:
> 
>  ftp://ftp.ccsf.org/htdig-patches/3.1.6/ssl.6

Thanks, Joe.  Yes, all the tm structure manipulation is gone from
Document::getdate() now, after my patch, so it needs to be removed
from any other patch that is applied to Document.cc.

I was mistaken earlier, though, about my patch making it possible to
remove the 'setlocale(LC_TIME, "C");' from htlib/Configuration.cc.
That call is still needed, because this locale setting will still affect
the strftime() call that generates the If-Modified-Since header, so we
can't allow LC_TIME to be set to another locale.  So, the Configuration.cc
locale handling has to stay as it is, but we do still solve the problems
we had with mktime and strptime.

I'd suggest a more meaningful name for the patch, though, like parsedate.0

-- 
Gilles R. Detillieux              E-mail: <gr...@sc...>
Spinal Cord Research Centre       WWW:    http://www.scrc.umanitoba.ca/~grdetil
Dept. Physiology, U. of Manitoba  Phone:  (204)789-3766
Winnipeg, MB  R3E 3J7  (Canada)   Fax:    (204)789-3930