According to Lachlan Andrew:
> I've found what seems to be a bug in the setting of the CONFIG
> template variable. It is set to the complete path name of the config
> file, but htsearch assumes that it will not have the leading path, or
> the .conf extension.
>
> Could someone please confirm that running "Refine this search" from a
> search result doesn't work because of this? I have written a patch,
> but want to make sure I'm not "fixing" a non-bug, so close to
> 3.2.0b5...
As far as I've been able to tell, the problem only shows up when the
"config" input parameter is not specified. In this case, htsearch uses
the value in defaults.cc, which is incorrectly set to DEFAULT_CONFIG_FILE.
It should default to "". I can change that and back out the hack in
Display.cc. So far, my testing has confirmed that htseach does the
right thing when the config input parameter is given, as long as the
hack in Display.cc is disabled. I don't see anything else in the code
that could make this happen, unless there's some wierd memory leak that
some of you are running into.
If you can confirm that this problem happens even when the config input
parameter is specified, then please get to the bottom of this before
3.2.0b5 goes out. The way I see things, the hack would break when
config is specified, and really break when collections are used (i.e.
more than one config parameter is given).
Speaking of collections, there's a bug with that and the new
boolean_keywords attribute. I'll commit a fix for this today too.
The old list must be destroyed before a new one is created the next time
through the loop.
--
Gilles R. Detillieux E-mail: <gr...@sc...>
Spinal Cord Research Centre WWW: http://www.scrc.umanitoba.ca/
Dept. Physiology, U. of Manitoba Winnipeg, MB R3E 3J7 (Canada)
|
