Re: [hpoj-devel] xojpanel changes

[<pa...@rc...>]

Joe Piolunek wrote:
> I made more changes to the xojpanel application that include the ability to 
> change the lcd text color, and many smaller code changes. The format of the 
> devicename string in the titlebar is a little different also.
Hi, Joe.  Thanks for your submission.  I apologize I haven't had a chance to
look at it yet, or at your earlier patch on May 3.  I assume this supercedes
the earlier patch, since you're including all the files.

> I also changed some of the filenames to those that I think make more sense 
> based on their contents and the application. Makefile.in is modified to 
> correspond to the new filenames.
While you're at it, I'm wondering if it would be feasible to combine the two
.cpp files into a single xojpanel.cpp, and rename the .h file to xojpanel.h.
It would make things a little more compact and less spread out.  I don't
know if there is some technical reason (i.e. Qt restriction) why the main()
function needs to be in a separate file from the classes, but I suppose it
was done that way originally to pave the way for something larger like the
xhpcontrol application we've talked about.  In the latter case, I think it's
safe to combine xojpanel/*.cpp for now, because it may be better to write
xhpcontrol from scratch anyway, using xojpanel as an example where
appropriate.

> I didn't know if I could make a reliable patch to send, so I tarred up all of 
> the modified files. I'm hoping filenames in CVS can be changed without 
> causing problems.
It's a matter of removing the old files and adding the new.  Of course, the
old files aren't really deleted, but rather moved into the "attic" directory,
which you can see in various parts of the codebase if you browse the CVS
repository on the web.

David