[hpoj-devel] Re: xojpanel 20 character patch

[<pa...@rc...>]

> Attached is a patch for xojpanel that enables the 20 - char lcd and 
> devicename display on the titlebar. It also contains the changes to the 
> pixmaps. 
Hi, Joe.  Thanks for sending that.  I've checked our respective changes into
CVS and updated the webpage accordingly.

> The lcd text lines now appear to be more centered horizontally ( I moved the 
> whole line to the right), but genuine centering would be hard to do. The 
> letters are still individually placed on the pixmap according to x,y 
> coordinates. I think the left side of the letter is placed on the x coord. If 
> the last letter is small, it will seem farther away from the right border 
> than if the letter is large.
Actually, now that you mention it, I think it looks a little odd to use a
proportional-space font in this context, especially in the middle of the
string.  It might look better if you went back to a fixed-space font.
It wasn't as obvious on your one example on your webpage, but I did notice
it a lot more when looking at many different messages.

> The lcd line2 is now 2 pixels lower than before, which will increase the line 
> separation. Could you check to see if line 2 is vertically centered in its 
> space?
It looks good to me.

> Another change ( which you may want to take a look at, though it's probably 
> ok ) is to apps/xojpanel/Makefile.in, which makes ojstatus.cpp dependant on 
> the pixmaps. It makes it a lot easier to test pixmap changes.
I'm glad you thought to do that.  Also, while looking over your changes,
which were fine BTW, I realized that I forgot to change the comment at the
top of the file after copying it from apps/cmdline/Makefile.in, so I fixed
that before checking it in.

David