Re: [hpoj-devel] patch for hpojlcd.xpm

[Joe P. <joe...@sn...>]

On Thursday 19 April 2001 07:50 am, David Paschal wrote:

<...>
> Hi, Joe.  I checked in your changes, including removing ojforlinux.xpm and
> adding hpoj_lcdmon.xpm.  Thanks for providing that.
>
> After checking in your changes, I went ahead and hacked xojpanel to support
> PTAL, but I didn't check it in.  Instead, I'm attaching the patch in case
> you want to make any adjustments to it.  If so, then you can send back a
> patch either against these changes or against the code in CVS.

I haven't seen anything in your code that needs changing, but I made some 
changes to add the devicename to the titlebar and to support a 20 character 
display.

I need to do a little more with the code (mostly cleaning it up) before 
sending a patch back, but I'm almost finished.

>
> Note that I added a requirement for a command-line parameter specifying the
> PTAL device name, such as "mlc:par:0".  It's hard to predict a default name
> that will work in all cases (parallel, USB, and eventually JetDirect).  One
> possible related enhancement would be to display the device name in the
> title bar.

I added the devicename  to the caption, taking it from argv[1] .
 
>
> With these changes, I could successfully run xojpanel on the following
> peripherals:
> Parallel-port: OfficeJet 700
> USB: PSC 750, OfficeJet K80, LaserJet 3200m

Your changes work with my 600 (on a parallel port).

When I attempted to start a second instance of xojpanel with the same 
devicename, this error mesg displayed:

]$ ./xojpanel mlc:par:0
ptalChannelOpen(chan=0x0808AD28): provider failed open!
Failed to open PML on device "mlc:par:0"!

The first instance of xojpanel continued to run though, which is an 
improvement. Neither of the daemons crashed or needed a restart.

>
> It turns out that the LaserJet 3200's display is 20 characters wide instead
> of 16, which causes some interesting scrolling patterns, especially when
> the line lengths are off by one.  Would it be much trouble to add four to
> the display width?

20 characters is now the default.

I made a new lcd background pixmap that doesn't have a spacing grid. It looks 
ok when displaying one line of text, but I haven't checked it for readability 
when both lines are displayed. I'll probably need to get some comments on 
that later.

xojpanel is wider now to accomodate the larger lcd pixmap.

I put up on my site a screenshot of the latest xojpanel (running) with your 
changes and mine. I think it looks reasonably good, but the graphics need 
some more work.

http://pages.cthome.net/jsp/hpoj-linux-gui/index.html 

-- 
Joe