From: <pa...@rc...> - 2001-04-19 11:49:33
|
Joe Piolunek wrote: > If you are planning to update any of the xojpanel files in CVS with the patch > I recently sent, hpojlcd.xpm also needs to be patched or resaved with a good > image editor like gimp. > > The problem was probably caused when I renamed hpojlcd.xpm without resaving > it, which causes the internal array name to be incorrect when attempting to > compile the pixmap into xojpanel. > > The pixmap "hpoj_lcdmon.xpm" I sent earlier replaces "ojforlinux.xpm", which > can be removed. Hi, Joe. I checked in your changes, including removing ojforlinux.xpm and adding hpoj_lcdmon.xpm. Thanks for providing that. After checking in your changes, I went ahead and hacked xojpanel to support PTAL, but I didn't check it in. Instead, I'm attaching the patch in case you want to make any adjustments to it. If so, then you can send back a patch either against these changes or against the code in CVS. Note that I added a requirement for a command-line parameter specifying the PTAL device name, such as "mlc:par:0". It's hard to predict a default name that will work in all cases (parallel, USB, and eventually JetDirect). One possible related enhancement would be to display the device name in the title bar. With these changes, I could successfully run xojpanel on the following peripherals: Parallel-port: OfficeJet 700 USB: PSC 750, OfficeJet K80, LaserJet 3200m It turns out that the LaserJet 3200's display is 20 characters wide instead of 16, which causes some interesting scrolling patterns, especially when the line lengths are off by one. Would it be much trouble to add four to the display width? David |