Re: [hpoj-devel] indentation and such

[<pa...@rc...>]

Burkhard Kohl wrote:
> I introduced quite some tab diffs, because the original source code
> did use almost no indentation, making it very hard to read. I use only
> tabs (no spaces except accidentally) which should expand to whatever the 
> editor has been set to. (8 spaces if vi default is used). I am a bit 
> puzzled - when I apply your diff the section where you say the spacing should 
> be right looks awful to me - it misses a lot of identation and it seems there 
> are mostly spaces (not tabs) in front of codelines. 
Hi, Burkhard.  I'm sorry about taking so long to get back with you on this.

Are you sure you don't have your tab stops set to 4?  Some of the changes in
your smp4 patch didn't look right unless I switched to 4 (in vi: ":set ts=4").

I played around with GNU indent a little tonight, and perhaps the best thing
to do is run "indent -kr -i8" on ieee12844.c with your code changes.  It's not
100% the style I use personally, but it's good enough for our purposes since
it cleans up the tab vs space consistency.  If you agree then I will go ahead
and commit this to CVS.  (You can look in the "ptal" directory to see an
example of my coding style, since I wrote all of that code myself.)

If you want I'll run indent on ieee12844pp.c too.  That will be a bit harder
because it screws up the switch blocks where I embed "case XX:" within the
"SET_STATE" macro and I'll have to selectively merge indent's changes.

I'm pretty sure the mailing list by itself doesn't munge tabs to spaces.
The patch to xojpanel I sent out on December 2 had tabs in the attachment,
and the message I got back from the list still had them as tabs.

> I think I know the reason but for tonight I am to tired to come up with
> a patch. Shortly, you added a couple of goto out:'s in mlc_sendmsg() where
> the original code just returned. That results in calls to kfree_skb
> on bufs that might be used later (e.g. after returning -EAGAIN).
Let's not worry about this.  Since your original changes work, I am taking
out my "changes".  If I get a chance later I will go back through and
identify specific places where I had questions and ask you about them.

David