Re: [hpoj-devel] xojpanel

[<pa...@rc...>]

Hi, Joe.

joe...@sn... said:
> There is another problem with either xojpanel or the low-level code.
> Sometimes xojpanel fails to start on the first try. This message is
> displayed  at the command line:
>
> "Error 0 (system error 100) in file mlccon.c, line 280: Unexpected
> error,  please post a bug report to hpo...@bs..."
I will fix that e-mail address.

> If I try to start it a second time, xojpanel usually starts and runs
> with no  problems that I can see.
I'm not sure what the problem here is, but the problem must be in the
low-level driver code.  Do you see any error messages in syslog
(/var/log/messages)?  You could also try using the "debug=1" parameter when
loading ieee12844pp.o, and maybe from that I can tell where it's going wrong.
Could you elaborate on the circumstances in which this happens?  For example,
does it only happen the first time after you load the drivers, or does it
happen after you power-cycle the peripheral, etc.?

> I also made it possible to load the pixmaps from a user-specified
> directory  chosen at build-time. I took most of your advice on
> creating a single pixmap  loading function.  It will be necessary for
> the pixmap path and its enclosing  quotes to be inserted in place of
>
> XOJPANEL_DEFAULT_PIXMAP_PATH 
>
> I hope what I did works correctly. It will correctly handle whatever
> path is  #defined in ojstatus.cpp, but I haven't tested it when
> controlling from  ./configure.
Super.  It looked fine to me.  I will hack this into the configure/build
sequence when I commit it to CVS.

> I removed most of the references to unicode and replaced #define
> UNICODE_SUPPORT with #define USE_QCHAR. 
OK.

> Do my recent changes to the pixmap loading code work correctly? Does
> it still segfault? 
I played with it a lot last night, and I'm no longer seeing the various
segfaults I previously reported.  Thanks for fixing that.

Attached is a patch containing some changes I made.  The second change adds
an explanation if xojpanel dies because the peripheral doesn't support LCD
readback.  The first change changes the poll rate from once to four times
per second, which greatly improved the response when I was scrolling through
menus really fast.  However, it's probably not worth actually putting in,
because I expect most people wouldn't need this level of responsiveness
given the extra overhead it introduces, and IIRC you previously indicated
some reason (debugging?) why you didn't want it to poll more than once per
second anyway.

I'm glad you added the license statement at the top of the files, but you
might want to add a copyright message, similar to what I did in the ptal
and ieee12844 directories.  If you do this then it would be proper to also
include a copyright for the original author, which I think was Andreas
Fester.  (Is this correct, Andreas?  And what copyright year should be
given for you?)

When should I start putting this into CVS?  Once I do, then it would be
preferable for additional changes to be made available as patches to
hpoj-devel, even if you continue to provide a downloadable package on your
website.

Am I correct in assuming that the only file I should remove from CVS is
lcd.bmp?  For the new files you provide, should I include
CHANGES-xojpanel_jsp (possibly renamed to just "CHANGES")?  It might be
easier to let the CVS checkin comments serve as the changelog.  What about
xojpanel.kdelnk (maybe?) and .directory (probably not)?

David