From: Mark P. <ms...@de...> - 2004-12-08 19:57:09
|
=2D----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tue, 7 Dec 2004 11:18 am, Cory Meisch wrote: > Hewlett-Packard is proud to announce the introduction of HP Linux > Imaging and Printing System (HPLIP). HPLIP is a complete single and > multi-function printing device connectivity solution for users of Linux > OS. The goal of this project is to provide =B4radically simple=A1 printin= g, > scanning, photo card access, and device management to the consumer and > business Linux user. Cory, Thanks for this long awaited release. A couple of issues from a Debian GNU/Linux perspective. =2E When following the Debian Installation instructions to the letter the update-rc.d command fails with the following: [...] update-rc.d: error: expected runlevel [0-9S] (did you forget "." ?) usage: update-rc.d [-n] [-f] <basename> remove update-rc.d [-n] <basename> defaults [NN | sNN kNN] update-rc.d [-n] <basename> start|stop NN runlvl [runlvl] [...] . -n: not really -f: force =2E In trying to generate a Debian package for hplip (I'm currently the Deb= ian maintainer for hpoj) DESTDIR is not honoured for the following installation candidates: error: /usr/lib/python2.3/site-packages/cupsext.so: Permission denied /usr/bin/install -c -m 644 xml/errors.xml /home/msp/src/hpinkjet.sf.net/hplip-0.8.2/debian/hplip/usr/h= ome/msp/src/hpinkjet.sf.net/hplip-0.8.2/debian/hplip/usr/hplip/data/xml/err= ors.xml error.png error: /usr/lib/python2.3/site-packages/pcardext.so: Permission denied /etc/hp/hplip.conf My build-log is available at: http://people.debian.org/~msp/hplip_0.8.2-1_i386.build It also tends to place of lot of arch independant files under /usr/hplip, t= his would be better has /usr/share/hplip, but the use of $(datadir) rather than $(prefix) in a number of places. What we did with davidp in hpoj was split up the install target into a user_install (for base files and applications) and root_install (for /etc/ & init.d files). The Debian package called user_install (honouring DETSDIR) to place the base files in the correct location, but didn't call root_install. Instead using the debian/rules to place /etc & init.d files. Could you look at a similar scheme for hplip as it would greatly help package maintainers and would be transparent to other users of the upstream source. Some other suggestions I have are: =2D --- hplip-0.8.2.orig/prnt/Makefile.in +++ hplip-0.8.2/prnt/Makefile.in @@ -115,9 +115,9 @@ sysconfdir =3D @sysconfdir@ target_alias =3D @target_alias@ =2D -hplipdir =3D $(prefix)/hplip =2D -prntdir =3D $(prefix)/hplip/prnt =2D -cupsextdir =3D $(prefix)/hplip/prnt/cupsext +hplipdir =3D $(datadir)/hplip +prntdir =3D $(datadir)/hplip/prnt +cupsextdir =3D $(datadir)/hplip/prnt/cupsext hplip_DATA =3D =2D --- hplip-0.8.2.orig/base/Makefile.in +++ hplip-0.8.2/base/Makefile.in @@ -93,7 +93,7 @@ sysconfdir =3D @sysconfdir@ target_alias =3D @target_alias@ =2D -hplipdir =3D $(prefix)/hplip/base +hplipdir =3D $(datadir)/hplip/base hplip_SCRIPTS =3D maint.py codes.py g.py mfpdtf2.py pml.py status.py async= =2Epy \ database.py __init__.py mfpdtf.py service.py utils.py async_qt.py \ =2D --- hplip-0.8.2.orig/data/Makefile.in +++ hplip-0.8.2/data/Makefile.in @@ -95,11 +95,11 @@ sysconfdir =3D @sysconfdir@ target_alias =3D @target_alias@ =2D -xmldir =3D $(prefix)/hplip/data/xml =2D -imagesdir =3D $(prefix)/hplip/data/images =2D -pcldir =3D $(prefix)/hplip/data/pcl =2D -ldldir =3D $(prefix)/hplip/data/ldl =2D -psdir =3D $(prefix)/hplip/data/ps +xmldir =3D $(datadir)/hplip/data/xml +imagesdir =3D $(datadir)/hplip/data/images +pcldir =3D $(datadir)/hplip/data/pcl +ldldir =3D $(datadir)/hplip/data/ldl +psdir =3D $(datadir)/hplip/data/ps ps_DATA =3D \ ps/testpage.ps.gz =2D --- hplip-0.8.2.orig/scan/Makefile.in +++ hplip-0.8.2/scan/Makefile.in @@ -93,7 +93,7 @@ sysconfdir =3D @sysconfdir@ target_alias =3D @target_alias@ =2D -hplipdir =3D $(prefix)/hplip/scan +hplipdir =3D $(datadir)/hplip/scan hplip_SCRIPTS =3D __init__.py pml_scanner.py sane.py scanner.py scl.py scl_scanner.py subdir =3D . =2D --- hplip-0.8.2.orig/ui/Makefile.in +++ hplip-0.8.2/ui/Makefile.in @@ -93,7 +93,7 @@ sysconfdir =3D @sysconfdir@ target_alias =3D @target_alias@ =2D -hplipdir =3D $(prefix)/hplip/ui +hplipdir =3D $(datadir)/hplip/ui hplip_SCRIPTS =3D \ advancedinfoform_base.py \ =2D --- hplip-0.8.2.orig/pcard/Makefile.in +++ hplip-0.8.2/pcard/Makefile.in @@ -118,9 +118,9 @@ noinst_PROGRAMS =3D ptest =2D -hplipdir =3D $(prefix)/hplip =2D -pcarddir =3D $(prefix)/hplip/pcard =2D -pcardextdir =3D $(prefix)/hplip/pcard/pcardext +hplipdir =3D $(datadir)/hplip +pcarddir =3D $(datadir)/hplip/pcard +pcardextdir =3D $(datadir)/hplip/pcard/pcardext hplip_DATA =3D =2D --- hplip-0.8.2.orig/Makefile.in +++ hplip-0.8.2/Makefile.in @@ -63,27 +63,27 @@ cd $$here/$$i; \ $(MAKE) $(AM_MAKEFLAGS) install; \ done =2D - $(install_script) $(PYTHON_SOURCES) $(PYTHON_SOURCES2) $(DESTDIR)$(prefix)/$(PACKAGE) + $(install_script) $(PYTHON_SOURCES) $(PYTHON_SOURCES2) $(DESTDIR)$(datadir)/$(PACKAGE) for i in $(PYTHON_SOURCES); do \ newname=3D$${i%.*}; \ =2D - mv $(DESTDIR)$(prefix)/$(PACKAGE)/$$i $(DESTDIR)$(prefix)/$(PACKAGE)/$$newname; \ + mv $(DESTDIR)$(datadir)/$(PACKAGE)/$$i $(DESTDIR)$(datadir)/$(PACKAGE)/$$newname; \ done =2D - $(mkinstalldirs) /etc/hp =2D - $(install_data) $(PACKAGE).conf /etc/hp/ =2D - echo -e "\n[$(PACKAGE)]\nversion=3D$(VERSION)\njdprobe=3D0\n" >> /etc/hp/$(PACKAGE).conf =2D - echo -e "[dirs]\nhome=3D$(DESTDIR)$(prefix)/$(PACKAGE)\n" >> /etc/hp/$(PACKAGE).conf + $(mkinstalldirs) $(DESTDIR)/etc/hp + $(install_data) $(PACKAGE).conf $(DESTDIR)/etc/hp/ + echo -e "\n[$(PACKAGE)]\nversion=3D$(VERSION)\njdprobe=3D0\n" >> $(DESTDIR)/etc/hp/$(PACKAGE).conf + echo -e "[dirs]\nhome=3D$(DESTDIR)$(prefix)/$(PACKAGE)\n" >>$(DESTDIR)/etc/hp/$(PACKAGE).conf Mark =2D----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFBt1x0oCzanz0IthIRAlKQAJ9WCwm/X4l4SUB3YVYRVjFDa8QcuACdGekc lwl4rUTV6raGsTeBhPTB8N8=3D =3DPMGI =2D----END PGP SIGNATURE----- |