wol...@gm... commented on revision r380 in project hoc.
Details are at http://code.google.com/p/hoc/source/detail?r=380
Score: Positive
General Comment:
I like it :-)
Line-by-line comments:
File: /branches/objc2/hoc/HOC/HOC/ID.hs (r380)
===============================================================================
Line 28: dPutWords = dPutStrLn . unwords
-------------------------------------------------------------------------------
No problem here, just an idea for the future: move that to some HOC.Debug
module, and add a Cabal flag to enable logging.
File: /branches/objc2/hoc/HOC/HOC/NewClass.hs (r380)
===============================================================================
Line 98: retainCif = getCifForSelector (undefined :: Class () -> ID () ->
IO (ID ()))
-------------------------------------------------------------------------------
This is wrong, the additional argument should not be declared in the CIF as
it only exists in Haskell land; the function that is exported to ObjC land
as the implementation for retain/release is still of type ID () -> IO (ID
())
File: /branches/objc2/hoc/HOC_cbits/MemoryManagement.m (r380)
===============================================================================
Line 96: objc_msgSendSuper(super, selRetain);
-------------------------------------------------------------------------------
Needs to be adapted for GNUstep. Never mind for now.
Respond to these comments at
http://code.google.com/p/hoc/source/detail?r=380
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
|
