#15 Issue with 'nacksonly' and suggestion for dumped files

[Francisco Saez]

Hello, first of all I want to let you know I am very pleased with this tool.
I hope you find this feedback useful.

I have one issue and one suggestion.

Issue: According to the example configuration provided, one of the debug options for [outgoing_socket] is supposed to dump all files, no matter they are ACKs or NAKs.

I quote lines 176 – 178 from “example.cfg”

   'nacksonly'       :   Defaults to True
       If set to True, only negative ACKs will be dumped to file.
       If set to False, all ACKs will be dumped.

If you set this option to “True” only NAK files will be dumped. Which I believe is the correct behavior.
But if you set this option to False you won’t get all Files, actually you will get only ACK files.

I have reviewed the code and found a conditional that prevents the dump of NAK files. As you can see in “handleMessage” method in “Common/workerThreads.py” on line 1259.

if self.__debugopts and self.__debugopts.get('nacksonly'):
    # dump the NACK
    self.__debugHandleAck(self.message)

I think NAK files should always be dumped.

Summarizing the issue consist in having the “nacksonly” option working as a switch between ACK and NAK files, instead of just dumping NAK files when is set to True and all files when is set to False.

Suggestion: Currently you can define the prefix and the suffix for dumped files, but the middle is set with a timestamp “AAAAMMDDHHMMSS”. As you can see in “__debugHandleAck” method in “Common/workerThreads.py”.

fpath = os.path.normpath(self.__debugopts.get('ackmsgdir') + '/' + self.__debugopts.get('ackmsgprefix') + isoDate + '_' + str(fileCounter).zfill(counterLength) + self.__debugopts.get('ackmsgsuffix'))
while os.path.exists(fpath):
    fileCounter += 1
    fpath = os.path.normpath(self.__debugopts.get('ackmsgdir') + '/' + self.__debugopts.get('ackmsgprefix') + isoDate + '_' + str(fileCounter).zfill(counterLength) + self.__debugopts.get('ackmsgsuffix'))

I think it will very useful to have a config option to change the “isoDate” for the MSA-3 or MSH-9 because in my opinion they contain a better way to uniquely identify the dumped files.

Kind regards.

Francisco Saez.