Menu

#95 Performance improvement SegmentFinder#matches

2.3
wont-fix
None
5
2016-12-18
2016-09-29
No

I was profiling some of our code which uses HL7, and I noticed that we had a large number of calls to java.util.Pattern#compile.

I tracked a number of them down to SegmentFinder#matches method. I would therefore suggest the patch below, which cuts down the number of Pattern#compile calls from 4 to 1.

The unit tests passes. I have written the code myself and would like to submit it under the same GPL/MPL license as the rest of the code.

Discussion

  • Niels Ull Harremoës

    oops - forgot to add the patch file before saving

     
  • Niels Ull Harremoës

    And I think this could go into the next minor release - it doesn't need to be milestone Future (but I cannot edit that).

     
  • Niels Ull Harremoës

    Duplicate of bug 242 - I hadn't noticed that it was already entered as a bug.
    https://sourceforge.net/p/hl7api/bugs/242/

    Please close or delete.

     
  • Christian Ohr

    Christian Ohr - 2016-12-18
    • status: open --> wont-fix
    • assigned_to: Christian Ohr
    • Group: Future --> 2.3
     
  • Christian Ohr

    Christian Ohr - 2016-12-18
     

Log in to post a comment.