Menu

#75 Meaningful error message log in HohRawServlet

2.1
closed-fixed
nobody
hoh (2)
5
2013-05-07
2013-01-29
No

In the HohRawServlet doPost method, when decoding the input, if a DecodeException is thrown, the error logged is not meaningful:

eg.
2013-01-29 16:11:42,049 ERROR [ca.uhn.hl7v2.hoh.raw.server.HohRawServlet] (http-0.0.0.0-8080-1) Request failure for /hohServlet

The problem is the following line of code, where the logger is not used correctly (I think):
ourLog.error("Request failure for " + theReq.getRequestURI(), e.getMessage(), e);

should be changed into something like:
ourLog.error("Request failure for " + theReq.getRequestURI(), e);

In this way the error cause would be logged.

Discussion

  • Giacomo Petronio

    The same applies to the following (same class):
    ourLog.error("Processing problem for " + theReq.getRequestURI(), e.getMessage(), e);

     
  • James Agnew

    James Agnew - 2013-01-30
    • status: open --> closed-fixed
     
  • James Agnew

    James Agnew - 2013-01-30

    Fix has been checked in as suggested. Thanks for reporting!

    We should have a beta out shortly which contains this fix.

     
  • Christian Ohr

    Christian Ohr - 2013-05-07
    • Group: Future --> 2.1
     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.