Menu

#222 isAllowUnknownVersions() not respected in CustomModelClassFactory

2.3
closed-fixed
None
5
2014-12-16
2014-12-05
No

CustomModelClassFactory.findClass() calls Parser.assertVersionExists(version) without wrapping it in isAllowUnknownVersions(). This causes custom mappings for unsupported (by HAPI) versions (whether or not they are supported by the Factory) to fail.

IMHO, I don't think CustomModelClassFactory should make this call at all:

  • The factory is constructed using a package or array of classnames that should (and in my testing do) explicitly constrain the supported versions.
  • If the package includes 2.7, it should work... if it doesn't include 2.7, it should (and does) fail.
  • Conversely, if the Factory does not have models for 2.2, the fact that HAPI supports that version is irrelevant.

Discussion

  • Christian Ohr

    Christian Ohr - 2014-12-15
    • Group: 2.2 --> 2.3
     
  • Christian Ohr

    Christian Ohr - 2014-12-16
    • status: open --> closed-fixed
    • assigned_to: Christian Ohr
     
  • Christian Ohr

    Christian Ohr - 2014-12-16

    removed check for unknown version in CustomModelClassFactories

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.