#103 Bug in parsing OML_O21, OML_O33, OML_O35 messages

[rjuncu]

While parsing one of these messages, if the sequence of segments is kind of :
MSH, PID, PV1, ORC, OBR, OBX, ORC, OBR, ORC, OBR (so, 3 batteries ordered), the parser interprets this as one battery and two prior results.

According to the IHE LAB TF spécification, the PV1 segment in the PRIOR_RESULT group is required, but in OML_OXX_PRIOR_RESULT_CLASSES, the OML_OXX_PATIENT_VISIT_PRIOR classes are added as optional. Changing this as required solve the problem, and I did this in my application.

I will attach here, differences (svn diff) only for the v.2.5.1 version, it is up to you to include this in the other versions.

Thanks for the job, this library is very helpfull.

Roméo

[rjuncu]

svn diff for changes needed to solve this problem

[Christian Ohr]

I saw this fixed as described in the patch. Closing issue.

[Anonymous]

Hi, I'm using HAPI 2.0 and this bug seems to be there. Reading the IHE specs, previous results shall have ORC-1=PR (see IHE LAB TF Vol2a, paragraph 1380).

BTW if I create an OML_O21 message from scratch with multiple ORC/OBR and parse back, I get an ambiguous result (only one ORC/OBR and the rest of the ORC/OBRs ans PRIOR RESULTS of the OBSERVATION_REQUEST).

I tried to disambuguate the ORC/OBR using TQ1: MSH ORC TQ1 OBR ORC TQ1 OBR
Prior results doesn't have TQ1 after ORC but it gets parsed and ORC/OBR 2..N still appear as prior results.

Attached my a test class.

Any ideas?
Thanks.

[Anonymous]

Hi, I'm using HAPI 2.0 and this bug seems to be there. Reading the IHE specs, previous results shall have ORC-1=PR (see IHE LAB TF Vol2a, paragraph 1380).

BTW if I create an OML_O21 message from scratch with multiple ORC/OBR and parse back, I get an ambiguous result (only one ORC/OBR and the rest of the ORC/OBRs ans PRIOR RESULTS of the OBSERVATION_REQUEST).

I tried to disambuguate the ORC/OBR using TQ1: MSH ORC TQ1 OBR ORC TQ1 OBR
Prior results doesn't have TQ1 after ORC but it gets parsed and ORC/OBR 2..N still appear as prior results.

Attached my a test class.

Any ideas?
Thanks.

[Anonymous]

Hi, I'm using HAPI 2.0 and this bug seems to be there. Reading the IHE specs, previous results shall have ORC-1=PR (see IHE LAB TF Vol2a, paragraph 1380).

BTW if I create an OML_O21 message from scratch with multiple ORC/OBR and parse back, I get an ambiguous result (only one ORC/OBR and the rest of the ORC/OBRs ans PRIOR RESULTS of the OBSERVATION_REQUEST).

I tried to disambuguate the ORC/OBR using TQ1: MSH ORC TQ1 OBR ORC TQ1 OBR
Prior results doesn't have TQ1 after ORC but it gets parsed and ORC/OBR 2..N still appear as prior results.

Attached my a test class.

Any ideas?
Thanks.

[Thibault Joseph]

The rjuncu correction work, can you integrate it into a new version of HAPI ?