#135 assignment in if statement in library header file that contains code

[Flammie Pirinen]

when using clang the flag diacritics header code spams following warnings for each compilation unit:

  :info:build ../../libhfst/src/implementations/optimized-lookup/../../HfstFlagDiacritics.h:170:39: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
  :info:build                 if(next_diacritic_pos = std::string::npos)
  :info:build                    ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
  :info:build ../../libhfst/src/implementations/optimized-lookup/../../HfstFlagDiacritics.h:170:39: note: place parentheses around the assignment to silence this warning
  :info:build                 if(next_diacritic_pos = std::string::npos)
  :info:build                                       ^
  :info:build                    (                                     )
  :info:build ../../libhfst/src/implementations/optimized-lookup/../../HfstFlagDiacritics.h:170:39: note: use '==' to turn this assignment into an equality comparison
  :info:build                 if(next_diacritic_pos = std::string::npos)
  :info:build                                       ^
  :info:build                                       ==

[Sam Hardwick]

This was fixed a while ago.