Menu
▾
▴
#10 wrongful assumption that chtype fits in 8 bits
gui.c uses a char array to store colors of the blocks on the overview area. this seems to work on ncurses, at lease on my system, but might just as well break on any other system, depending on the exact implementation of the curses library. Some curses will fit colors in 8 bits indeed, but not others (heck, some even use 32 bit values for color pairs!).
Instead, hexcompare should use the "chtype" type provided by the curses API, and rely on a sizeof(chtype) for all allocations.
I am willing to provide a patch for this, but I need to know whether hexcompare is still actively maintained or not (I'm starting to get lost in my patches..).
actually this is not right - hexcompare uses a char array to hold indexes that are fed to COLOR_PAIR(), not pairs themselves, so it's all good.