Menu

#41 Code cleanup - CharacterSheetGUI.asc

Room Scripts
fixed
nobody
Scripting (65)
2014-11-27
2014-04-29
No

CharacterSheetGUI.asc is filled with a lot of duplicate code that needs to be cleaned up, at the same time the the entire script can get a quality check.

I already did some work on this, but it was removed from the master build, don't know if this was intentional.

Discussion

  • Robert Kety

    Robert Kety - 2014-04-29

    I'll look into the missing code. As far as I know, everything you've submitted should be in the master.

     
  • Robert Kety

    Robert Kety - 2014-04-29

    Problem solved. When I pushed the new Difficulty Slider, I also pushed the old CharacterSheetGUI.asc accidentally. I've reverted the file. Sorry if I delayed you at all.

     
  • Per Olav Flaten

    Per Olav Flaten - 2014-04-29

    This could become even more neat if anyone figure out how to reference the actual stats of the HeroData struct as a input argument.

     
  • Robert Kety

    Robert Kety - 2014-04-29

    There's a pretty complex work around that might help with that; however, at 100+ lines of code, it's not very practical.

    http://www.adventuregamestudio.co.uk/wiki/Referencing_custom_struct_types

     
  • Robert Kety

    Robert Kety - 2014-11-27
    • status: open --> fixed
     

Log in to post a comment.

MongoDB Logo MongoDB