later in this file they're (all, but at lease 2?) incremented (remember:
const(?!)):
[...]
for (; InLen; In++, InLen--)
{
switch(decode = g_Decode[*In])
{
case SKIP: break; // skip whitespace
case FAIL: invalCount++; break; // count invalid characters
case PAD: m_PadCount++; break; // count pad characters
default:
// found a non-pad character, so if we had previously found a
// pad, that pad was an error [...]
later in this file they're (all, but at lease 2?) incremented (remember:
const(?!)):
[...]
for (; InLen; In++, InLen--)
{
switch(decode = g_Decode[*In])
{
case SKIP: break; // skip whitespace
case FAIL: invalCount++; break; // count invalid characters
case PAD: m_PadCount++; break; // count pad characters
default:
// found a non-pad character, so if we had previously found a
// pad, that pad was an error [...]
later in this file they're (all, but at lease 2?) incremented (remember:
const(?!)):
[...]
for (; InLen; In++, InLen--)
{
switch(decode = g_Decode[*In])
{
case SKIP: break; // skip whitespace
case FAIL: invalCount++; break; // count invalid characters
case PAD: m_PadCount++; break; // count pad characters
default:
// found a non-pad character, so if we had previously found a
// pad, that pad was an error [...]
later in this file they're (all, but at lease 2?) incremented (remember:
const(?!)):
[...]
for (; InLen; In++, InLen--)
{
switch(decode = g_Decode[*In])
{
case SKIP: break; // skip whitespace
case FAIL: invalCount++; break; // count invalid characters
case PAD: m_PadCount++; break; // count pad characters
default:
// found a non-pad character, so if we had previously found a
// pad, that pad was an error [...]
later in this file they're (all, but at lease 2?) incremented (remember:
const(?!)):
[...]
for (; InLen; In++, InLen--)
{
switch(decode = g_Decode[*In])
{
case SKIP: break; // skip whitespace
case FAIL: invalCount++; break; // count invalid characters
case PAD: m_PadCount++; break; // count pad characters
default:
// found a non-pad character, so if we had previously found a
// pad, that pad was an error [...]
later in this file they're (all, but at lease 2?) incremented (remember:
const(?!)):
[...]
for (; InLen; In++, InLen--)
{
switch(decode = g_Decode[*In])
{
case SKIP: break; // skip whitespace
case FAIL: invalCount++; break; // count invalid characters
case PAD: m_PadCount++; break; // count pad characters
default:
// found a non-pad character, so if we had previously found a
// pad, that pad was an error [...]
later in this file they're (all, but at lease 2?) incremented (remember:
const(?!)):
[...]
for (; InLen; In++, InLen--)
{
switch(decode = g_Decode[*In])
{
case SKIP: break; // skip whitespace
case FAIL: invalCount++; break; // count invalid characters
case PAD: m_PadCount++; break; // count pad characters
default:
// found a non-pad character, so if we had previously found a
// pad, that pad was an error [...]
I cant commit anc push becuase I'm in this x64 hackec state.
Obviuos errors annoy me though:
In Base64.cpp three variables are declared:
[...]
const BYTE SKIP = 0xFF;
const BYTE FAIL = 0xFE;
const BYTE PAD = 0xFD;
[...]
later in this file they're (all, but at lease 2?) incremented (remember:
const(?!)):
[...]
for (; InLen; In++, InLen--)
{
switch(decode = g_Decode[*In])
{
case SKIP: break; // skip whitespace
case FAIL: invalCount++; break; // count invalid characters
case PAD: m_PadCount++; break; // count pad characters
default:
// found a non-pad character, so if we had previously found a
// pad, that pad was an error
[...]
Solution:
[...]
BYTE SKIP = 0xFF;
BYTE FAIL = 0xFE;
BYTE PAD = 0xFD;
[...]
Regards.
No wait.... WTF?! Why did the errors disappear?! Never mind....
Regards.
On Tue, Oct 30, 2018 at 8:06 PM sbrothy@gmail.com wrote:
A cast to constness for the value being compared in the case statement
might also work.
Regards.
On Tue, Oct 30, 2018 at 8:07 PM sbrothy@gmail.com wrote:
[...]
for (; InLen; In++, InLen--)
{
switch(decode = g_Decode[*In])
{
case SKIP: break; // skip whitespace
case FAIL: invalCount++; break; // count invalid characters
case PAD: m_PadCount++; break; // count pad characters
default:
[...]
Bizarrely, this takes care of some of the C2105 errors "++ needs lvalue!" :
[...]
for (; InLen; In++, InLen--)
{
switch(decode = g_Decode[*In])
{
case SKIP: break; // skip whitespace
case FAIL: invalCount = invalCount + 1; break; // count invalid characters
case PAD: m_PadCount = m_PadCount + 1 ; break; // count pad characters
default:
[...]
Don't ask. Just accept. Compiler quirk perhaps....
Regards.
On Tue, Oct 30, 2018 at 8:09 PM Soren Bro sbrothy@users.sourceforge.net
wrote:
Changing "m_DecoderState++" to "m_DecoderState = m_DecoderState + 1"
likewise does the trick.
On Tue, Oct 30, 2018 at 8:33 PM sbrothy@gmail.com wrote:
And....no Ignore, .dammit.
On Tue, Oct 30, 2018 at 8:36 PM sbrothy@gmail.com wrote:
Sorry. Thinking out loud. I'm not impressed.
On Tue, Oct 30, 2018 at 9:17 PM sbrothy@gmail.com wrote: