Menu

Code analysis. Cont.

Soren Bro
2018-10-03
2018-10-04
  • Soren Bro

    Soren Bro - 2018-10-03

    I didn't check.

    I was to busy showing off with a smartpointer in the code
    (std::unique_ptr), trying to work around the JWnd::SendMessage and
    JWnd::PostMessage problem. They're not static, and the JWnd class
    encapsulates a HWND member (it even overrides operator HWND(?)).

    Intuitively, something looks needlessly complicated here.

    Since I don't know the memory penalty for creating them "on the stack", I
    decided to create them on the heap. Hence the autoptr.

    Even without smartpointers my scheme may work. What worries me is that the
    code, again, is in an auto generated section!

    I think we need to have a discussion about this problem. This is the only
    place I can find a reference to JWnd. I'm pretty sure we may be better
    of(f) without it.

    tl;dr:

    I don't like JWnd. It seems needlessly complicated and it's only used in
    that one file (workbook.h). I'd like it out.

    If OT501 is indeed the only static library then that's the best news I've
    heard so far. Isn't OT501 basically the user interface and the ineffable
    despicability we reluctanty refer to as Stingray?

    Regards

    On Wednesday, October 3, 2018, Pete Maclean petemaclean@users.sourceforge.net wrote:

    That may indeed be the answer. I have suspected since early on that this
    is the case.


    Explain this please, Pete. Code analysis.
    https://sourceforge.net/p/hermesmail/discussion/general/thread/fc1ba947cb/?limit=25#c775/3080/0990/aad0


    Sent from sourceforge.net because you indicated interest in
    https://sourceforge.net/p/hermesmail/discussion/general/

    To unsubscribe from further messages, please visit
    https://sourceforge.net/auth/subscriptions/

    --
    Søren Bro Thygesen

     
    • Soren Bro

      Soren Bro - 2018-10-03

      (AFK)

      To clear up:

      I'm not happy with the fact that it's static, but this implies that the
      rest are DLLs and, for the most part, work, no?

      Now you're gonna puncture my "happy-balloon" somehow. I just know it.

      Regards

      On Wednesday, October 3, 2018, Soren Bro sbrothy@users.sourceforge.net
      wrote:

      I didn't check.

      I was to busy showing off with a smartpointer in the code
      (std::unique_ptr), trying to work around the JWnd::SendMessage and
      JWnd::PostMessage problem. They're not static, and the JWnd class
      encapsulates a HWND member (it even overrides operator HWND(?)).

      Intuitively, something looks needlessly complicated here.

      Since I don't know the memory penalty for creating them "on the stack", I
      decided to create them on the heap. Hence the autoptr.

      Even without smartpointers my scheme may work. What worries me is that the
      code, again, is in an auto generated section!

      I think we need to have a discussion about this problem. This is the only
      place I can find a reference to JWnd. I'm pretty sure we may be better
      of(f) without it.

      tl;dr:

      I don't like JWnd. It seems needlessly complicated and it's only used in
      that one file (workbook.h). I'd like it out.

      If OT501 is indeed the only static library then that's the best news I've
      heard so far. Isn't OT501 basically the user interface and the ineffable
      despicability we reluctanty refer to as Stingray?

      Regards

      On Wednesday, October 3, 2018, Pete Maclean petemaclean@users.sourceforge.
      net wrote:

      That may indeed be the answer. I have suspected since early on that this
      is the case.


      Explain this please, Pete. Code analysis.
      https://sourceforge.net/p/hermesmail/discussion/general/
      thread/fc1ba947cb/?limit=25#c775/3080/0990/aad0


      Sent from sourceforge.net because you indicated interest in
      https://sourceforge.net/p/hermesmail/discussion/general/

      To unsubscribe from further messages, please visit
      https://sourceforge.net/auth/subscriptions/

      --
      Søren Bro Thygesen


      Code analysis. Cont.
      https://sourceforge.net/p/hermesmail/discussion/general/thread/0231d9bd8e/?limit=25#4ea0


      Sent from sourceforge.net because you indicated interest in
      https://sourceforge.net/p/hermesmail/discussion/general/

      To unsubscribe from further messages, please visit
      https://sourceforge.net/auth/subscriptions/

      --
      Søren Bro Thygesen

       
    • Ted Matavka

      Ted Matavka - 2018-10-03

      At 02:30 PM 10/3/2018, you wrote:

      If OT501 is indeed the only static library then that's the best news
      I've heard so far. Isn't OT501 basically the user interface and the
      ineffable despicability we reluctanty refer to as Stingray?

      OT501 stands for Objective Toolkit 5.01. So, yes. That is what we
      loosely refer to as Stingray. More specifically, Stingray is the
      name of the company that first wrote OT (in other words, before they
      turned into a bunch of a-holes). Saying "Stingray" to mean Objective
      Toolkit is kind of like saying "Google" to mean the Chrome web
      browser, or saying "Microsoft" to mean Windows.

      As for the history of that company, Stingray Inc. was bought out by
      Rogue Wave, then Rogue Wave was bought out by Quovadx. When Quovadx
      was bought out by a bunch of investment bankers, they decided to spin
      off Rogue Wave into a separate company again.

      Regards

      On Wednesday, October 3, 2018, Pete Maclean <mailto: petemaclean@users.sourceforge.net="">petemaclean@users.sourceforge.net wrote:</mailto:>

      That may indeed be the answer. I have suspected since early on that
      this is the case.

       

Log in to post a comment.