Menu

#3 Stop Infinite loop when connection pointer is NULL

open
nobody
None
5
2005-06-01
2005-06-01
No

This patch breaks out with a temporary auth failure
when the database connection pointer is NULL, and fails
to reconnect for a any reason.

Otherwise we end up in an infinite loop, unable to open
an SQL connection.

I'm not 100% confident that this fix is the right one.
However it is the best I can get from my level of
understanding of the code.

Discussion

  • Russell Smith

    Russell Smith - 2005-06-01

    Stop infinite loop

     
  • Russell Smith

    Russell Smith - 2005-06-01

    Logged In: YES
    user_id=361841

    The debate is whether sql_open and sql_close should manage
    available connections more effectively. Due to the limited
    number of comments in the code, I have been unable to work
    out the exact use of available connection. And therefore
    how it should be treated.

    I will continue to look into it, and post further comments.

     

Log in to post a comment.