#48 wiper.sh misses free blocks in Group 0

closed-fixed
nobody
None
5
2012-09-28
2011-07-18
MixRamp
No

I was trying out wiper.sh on a tiny filesystem before letting it loose on a real one and was confused when it reported no free blocks to trim. This filesystem only has one group and the awk script within wiper.sh was not noticing it. The part of the awk script is:

/^Group [1-9][0-9]*:/ { ## Second stage output from dumpe2fs:
in_groups = 1
next
}

I changed the [1-9] to [0-9] and it now trims the correct blocks. I don't think there is a problem with this change but I could be missing something.

Discussion

  • Mark Lord

    Mark Lord - 2012-09-28
    • status: open --> closed-fixed
     
  • Mark Lord

    Mark Lord - 2012-09-28

    Mmm.. good catch. I messed up that particular regex. I think I'll just let it do what you suggest. It was trying to be more clever and reject suspicious group numbers such as 01 or 0123 etc..

     

Log in to post a comment.