game7 (Between) - Infinite loop of errors in server.php
Brought to you by:
jcr13
Menu
▾
▴
#8 game7 (Between) - Infinite loop of errors in server.php
In game7 (Between), as of this writing the server at http://www.northcountrynotes.org/game7/server.php is down because the database can't be connected, resulting in an infinite recursion of errors. The infinite recursion is caused by the code in server.php:
gs_connectToDatabase() calls mysql_connect() and when the latter fails, it calls gs_fatalError(). In turn, gs_fatalError() calls gs_log() which, when $enableLog is true, attempts to insert the error into the database. Since there's no connection, that in turn generates an error which results in another call to gs_fatalError(), which calls gs_log() which attempts to insert the error, which fails and calls gs_fatalError() and so on and on, until PHP crashes after about 33 MB transmitted.
A possible fix is to detect if there's a database connection, and avoid inserting errors into the database if not. Another possible fix is to avoid calling gs_fatalError() in case mysql_connect() fails, using die() or similar instead. Another one is to avoid calling gs_queryDatabase() for logging errors, and instead ignore any errors resulting from the log insertion. Or to instrument gs_queryDatabase() with a parameter that allows it to ignore errors, and use it in gs_log().
Hey, thanks for reporting this!
The database was horked for some reason, so I re-built it. It's working now.... though I realie that the ServerFinder URL is also not working, because of HTTP vs HTTPS redirects. I'm posting a note about that on the official page for the game.