Re: [hatari-devel] Issues in RS232 code and other mysteries

[Thomas H. <th...@bl...>]

On Wed, 30 Jul 2008 03:19:07 +0300, Eero Tamminen <oa...@he...>
wrote:
> 
>> RS232 emulation is done at the hardware (IO registers) level, there's no
>> need to handle it in gemdos.c, too.
> 
> Hm.  The gemdos.c had at the top this:
>   Bugs/things to fix:
>   * RS232
> ?
> 
> Are you saying that the currently commented out gemdos 0x3, 0x4, 0x12,
> 0x13 stuff could be just removed?

Yes, it's not necessary anymore.

> I was also thinking of adding support for getting screenshots in PNG
> format
> (doing animation recording with BMPs eats disk really fast), I don't
think
> adding support for that to the screenshot functionality would be hat much
> work (in addition to adding support for being able to specify screen shot
> dir and name).  Do you have any opinion on adding libpng/libz dependency
> to Hatari?

libpng support (or maybe rather SDL_image?) would be nice... but please add
a proper autoconf test for it so that Hatari still compiles without the
lib, too.

>> > - bDisableKeyRepeat config (file) option cannot be set from internal
>> >   Hatari UI or command line, what it's used for?
>>
>> Seems to be old code from WinSTon - in WinSTon there was a GUI option
>> to change it. Don't know if it is still useful in Hatari, if you have
>> some spare time you can try if it makes a difference when you change
>> it...
> 
[...]
> 
> Can you think a case where it would be needed?
> (especially as it can be set only from config file)

As I said, WinSTon had an GUI option for this. So somebody should check if
this is still useful for Hatari, too, and then either add a GUI option in
Hatari, too, or remove it completely. 

>> No, the _ReadByte() and _WriteByte() functions are used for the memory
>> mapped IO functions (in ioMemTab*.c) only.
> 
> OK.  In that case it could be better to rename the IO read/write stuff as
> such (_IOReadByte()), but I guess that's a bit useless code churn.

It's good the way it currently is. I like it that way. No need to change
this.

 Thomas