Re: [Haskelldb-users] Request for code review: Patch removing "distinct" option, adds "unique" function

[Bjorn B. <bri...@cs...>]

On Dec 19, 2007, at 18:28 , Justin Bailey wrote:

> On Dec 18, 2007 3:33 AM, Bjorn Bringert <bri...@cs...> =20
> wrote:
>> this looks good. I haven't run the testsuite yet, since it still
>> requires hs-plugins. I really should get around to fixing that. Hope
>> seems to run fine with it.
>
> I ran some of the tests against postgres and they worked.
> Unfortunately any test involving "calendartime" failed (seemed to be
> unable to parse a timezone) and I didn't have time to track down the
> root cause.

There are various know problems like that with different combinations =20=

of back-ends and drivers. Help with fixing them would be very =20
welcome. These things are mostly problems in HDBC or HSQL, or in how =20
HaskellDB uses them. The root cause is generally inconsistencies =20
between the different database implementations.

>> I'll be happy to push this to the main repo. Would it be possible for
>> you to send me an updated patch with only the necessary changes? Some
>> of the changes in the patch seem to only affect whitespace. I prefer
>> to keep patches minimal.
>
> I'd be glad to do that, but how can I update my recorded darcs patch?
> I've also continued to code on my working copy so it's evolved since I
> recorded the patch submitted. My darcs-fu is not very strong.

There are several possibilities. If you haven't touched the lines =20
with white-space changes, you could change them back to their =20
original state, and then use 'darcs amend-record' to update your =20
patch. Asking in #darcs might be best. If this becomes too difficult, =20=

I could accept the patch as it is.

/Bj=F6rn