Re: [Hamlib-developer] Rotator Dummy Issue at 180 degrees

[David B. <da...@ba...>]

That would make more sense than magic numbers. The same would go for the elevation values.

-----Original Message-----
From: George Baltz <geo...@gm...> 
Sent: 30 September 2025 19:41
To: ham...@li...
Subject: Re: [Hamlib-developer] Rotator Dummy Issue at 180 degrees

I wonder if those should just be using caps->min_az and caps->max_az?

On 9/30/25 1:01 PM, David Balharrie wrote:
> The Dummy rotator has a Min_Azimuth of -180 and Max_Azimuth of 450 degrees. Issuing set position commands with these values confirms this.
>
> It looks like the error is here
>
>      case ROT_MOVE_CCW:
>          return dummy_rot_set_position(rot, -180, priv->target_el);
>
>      case ROT_MOVE_CW:
>          return dummy_rot_set_position(rot, 180, priv->target_el);
>
> case ROT_MOVE_CW should be this...
>
>      case ROT_MOVE_CW:
>          return dummy_rot_set_position(rot, 450, priv->target_el);
>
> 73 de David M0DGB/G8FKH
>
> -----Original Message-----
> From: Nate Bargmann <n0...@n0...>
> Sent: 29 September 2025 18:18
> To: ham...@li...
> Subject: Re: [Hamlib-developer] Rotator Dummy Issue at 180 degrees
>
> * On 2025 29 Sep 09:48 -0500, David Balharrie wrote:
>> I rotated the Dummy Rotator to 180, then issued a Rotate CW (Right) 
>> from 180 and nothing happened. The command returned ok. You can do a 
>> rotate to a bearing ok. This can be demonstrated in rotctl. It is 
>> present in versions 3.6.2 through 4.7.
>>
>> I don't see the Dummy folder in rotators, otherwise I would have 
>> looked at the source. Where is Dummy Rotator located?
> It lives under rigs/dummy:
>
> https://github.com/Hamlib/Hamlib/blob/master/rigs/dummy/rot_dummy.c
>
> It probably should've been broken out under rotators, but due to historical reasons, here we are.
>
> 73, Nate
>
> --
> "The optimist proclaims that we live in the best of all possible worlds.  The pessimist fears this is true."
> Web: https://www.n0nb.us
> Projects: https://github.com/N0NB
> GPG fingerprint: 82D6 4F6B 0E67 CD41 F689 BBA6 FB2C 5130 D55A 8819
>
>
>
> _______________________________________________
> Hamlib-developer mailing list
> Ham...@li...
> https://lists.sourceforge.net/lists/listinfo/hamlib-developer


_______________________________________________
Hamlib-developer mailing list
Ham...@li...
https://lists.sourceforge.net/lists/listinfo/hamlib-developer