[Hamlib-developer] [Hamlib/Hamlib] 744fe5: Remove redundant path from BUILT_SOURCES

[Nate B. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/Hamlib/Hamlib
  Commit: 744fe5a066e3656907ea7f59d08e9ec4545cc993
      https://github.com/Hamlib/Hamlib/commit/744fe5a066e3656907ea7f59d08e9ec4545cc993
  Author: Jan Engelhardt <ej...@in...>
  Date:   2025-09-26 (Fri, 26 Sep 2025)

  Changed paths:
    M src/Makefile.am

  Log Message:
  -----------
  Remove redundant path from BUILT_SOURCES

Re: GitHub Issue #1895

In response to a query to the automake mailing list, this reply was
received:

On Wednesday 2025-09-24 19:05, Nate Bargmann wrote:

>make[1]: don't know how to make ./hamlibdatetime.h. Stop

Something wanted to make "./hamlibdatetime.h", but you only provide
a rule for "hamlibdatetime.h":

>hamlibdatetime.h: FORCE
>       @if test -x $(top_srcdir)/.git ; then \
>               echo "/* This date time is from the last non-merge commit to Hamlib. */" > $(builddir)/$(@F).tmp ;\
>               echo "#define HAMLIBDATETIME "\"$$(TZ=UTC git --git-dir=$(top_srcdir)/.git log --no-merges
+--date='format-local:%Y-%m-%dT%H:%M:%SZ SHA=' --format='%cd' -n 1)$$(git --git-dir=$(top_srcdir)/.git log --no-merges -n 1 | head
+-n 1 | cut -c8-13)\"  >> $(builddir)/$(@F).tmp ;\

The distinction is important.

>BUILT_SOURCES = $(builddir)/hamlibdatetime.h

All targets are already relative to ${builddir},
so explicitly mentioning ${builddir} is wrong for
targets, and redundant in the recipe.

----------------------

Removing "$(builddir)/" allows FreeBSD make to enter the rule.  GNU make
wasn't bothered by the prepending of the path when comparing to the
Makefile target.


  Commit: 34fa8d0e2fc9eeb21e1d4f86df65dfc7c1c135e4
      https://github.com/Hamlib/Hamlib/commit/34fa8d0e2fc9eeb21e1d4f86df65dfc7c1c135e4
  Author: Nate Bargmann <n0...@n0...>
  Date:   2025-09-26 (Fri, 26 Sep 2025)

  Changed paths:
    M src/Makefile.am

  Log Message:
  -----------
  Refactor hamlibdatetime.h target

Re: GitHub Issue #1895

Thanks to inspiration from Jan Engelhardt <ej...@in...> via the GNU
automake mailing list on Thu, 25 Sep 2025 20:40:21 +0200 (CEST):
https://lists.gnu.org/archive/html/automake/2025-09/msg00013.html
The 'diff' command has been wrapped inside an 'if' conditional to
hopefully hide its return value from FreeBSD make.

Also make a couple other small changes.


  Commit: 0d122f6b1a56a5ed9424dd11ac335cd37093f78f
      https://github.com/Hamlib/Hamlib/commit/0d122f6b1a56a5ed9424dd11ac335cd37093f78f
  Author: Nate Bargmann <n0...@n0...>
  Date:   2025-09-27 (Sat, 27 Sep 2025)

  Changed paths:
    M src/Makefile.am

  Log Message:
  -----------
  Restore information message from diff

Make sure tab preceeds all indented lines.


  Commit: d09f6b5dab19b6fc851b884dbcf8e637529d0a90
      https://github.com/Hamlib/Hamlib/commit/d09f6b5dab19b6fc851b884dbcf8e637529d0a90
  Author: Nate Bargmann <n0...@n0...>
  Date:   2025-09-27 (Sat, 27 Sep 2025)

  Changed paths:
    M src/Makefile.am

  Log Message:
  -----------
  Merge GitHub PR #1926


Compare: https://github.com/Hamlib/Hamlib/compare/dbea10e65524...d09f6b5dab19

To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications