Re: [Hamlib-developer] [Hamlib/Hamlib] 83ed5a: [src] Remove unused includes

[George B. <geo...@gm...>]

On 9/2/25 5:11 PM, Daniele Forsi wrote:
> George Baltz:
>
>> Guess I should have looked at the details, not just the description...
> always, especially if there is a bunch of files
>
>> This removes a large part of the prep work already done for the
>> refactoring of include files in 5.0.
> What the reason of unconditionally including files that aren't used?
> How that can be tested?
>
> The fileds modified in src/ are 2 *.h and 23 *.c
>
> Of course these commits can be easily reverted, but you aren't clearly
> talking about errno.h or stdio.h and the like.
>
> Which of the following unused includes should be added back? The
> number is the quantity of lines removed.
>
>       1 -#include "config.h"
>       2 -#include <errno.h>
>       2 -#include <fcntl.h>
>       1 -#include "hamlib/amplifier.h"
>      13 -#include "hamlib/port.h"
The port,h files are conditionally included in rig.h (now). They won't 
be in 5.0.  The entire code base needs to be updated before the includes 
can be tested.
>       3 -#include "hamlib/rig.h"
>       1 -#include "hamlib/rotator.h"
>       3 -#include "iofunc.h"
>       1 -#include "misc.h"
>       1 -#include "rot_conf.h"
>       1 -#include <stdio.h>
>       3 -#include <stdlib.h>
>       8 -#include <string.h>
>       3 -#  include <sys/param.h>
>       4 -#include <sys/stat.h>
>       3 -#include "token.h"
>       8 -#include <unistd.h>
>       1 -#include <unistd.h>  /* UNIX standard function definitions */
>