Re: [Hamlib-developer] [Hamlib/Hamlib] 39e155: Fix include config.h

[George B. <geo...@gm...>]

And another one

On 8/31/25 8:20 PM, Nate Bargmann via Hamlib-developer wrote:
>    Branch: refs/heads/master
>    Home:   https://github.com/Hamlib/Hamlib
>    Commit: 39e155efe71f9f2a84f42b5f64f510135173aa85
>        https://github.com/Hamlib/Hamlib/commit/39e155efe71f9f2a84f42b5f64f510135173aa85
>    Author: Daniele Forsi IU5HKX <iu...@gm...>
>    Date:   2025-08-30 (Sat, 30 Aug 2025)
>
>    Changed paths:
>      M lib/precise_time.c
>      M rigs/anytone/anytone.c
>      M rigs/barrett/barrett.c
>      M rigs/dummy/dummy.c
>      M rigs/dummy/flrig.c
>      M rigs/dummy/netrigctl.c
>      M rigs/dummy/quisk.c
>      M rigs/dummy/tci1x.c
>      M rigs/dummy/trxmanager.c
>      M rigs/kit/usrp_impl.cc
>      M rigs/winradio/g313-posix.c
>      M rigs/winradio/linradio/wrg313api.c
>      M rotators/androidsensor/androidsensor.cpp
>      M rotators/grbltrk/grbltrk.c
>      M security/AESStringCrypt.c
>      M src/fifo.c
>      M src/parallel.h
>      M tests/rigtestlibusb.c
>      M tests/rigtestmcastrx.c
>      M tests/testnet.c
>
>    Log Message:
>    -----------
>    Fix include config.h
>
> It should be included, with its path, before any hamlib include
> and before any #ifdef that uses the symbols that it defines.

This is OK as far as it goes, but ignores a very important fact - 
config.h also contains definitions that may be used by any system 
include.  For simple cases (like Hamlib) the *_SOURCE macros are the 
important ones, but for more complex uses(e.g., cross-compilation) it 
can get quite hairy.

If `config.h` is included, it should be before ANY other include.

>
>    Commit: 43b84ee56a66c19844c5efcb63f1217f57fac4c2
>        https://github.com/Hamlib/Hamlib/commit/43b84ee56a66c19844c5efcb63f1217f57fac4c2
>    Author: Nate Bargmann <n0...@n0...>
>    Date:   2025-08-31 (Sun, 31 Aug 2025)
>
>    Changed paths:
>      M lib/precise_time.c
>      M rigs/anytone/anytone.c
>      M rigs/barrett/barrett.c
>      M rigs/dummy/dummy.c
>      M rigs/dummy/flrig.c
>      M rigs/dummy/netrigctl.c
>      M rigs/dummy/quisk.c
>      M rigs/dummy/tci1x.c
>      M rigs/dummy/trxmanager.c
>      M rigs/kit/usrp_impl.cc
>      M rigs/winradio/g313-posix.c
>      M rigs/winradio/linradio/wrg313api.c
>      M rotators/androidsensor/androidsensor.cpp
>      M rotators/grbltrk/grbltrk.c
>      M security/AESStringCrypt.c
>      M src/fifo.c
>      M src/parallel.h
>      M tests/rigtestlibusb.c
>      M tests/rigtestmcastrx.c
>      M tests/testnet.c
>
>    Log Message:
>    -----------
>    Merge GitHub PR #1873
>
>
> Compare: https://github.com/Hamlib/Hamlib/compare/d227444aa60a...43b84ee56a66
>
> To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications
>
>
> _______________________________________________
> Hamlib-developer mailing list
> Ham...@li...
> https://lists.sourceforge.net/lists/listinfo/hamlib-developer