Re: [Hamlib-developer] [Hamlib/Hamlib] 83ed5a: [src] Remove unused includes

[George B. <geo...@gm...>]

Guess I should have looked at the details, not just the description...

On 8/31/25 8:04 PM, dforsi via Hamlib-developer wrote:
>    Branch: refs/heads/master
>    Home:   https://github.com/Hamlib/Hamlib
>    Commit: 83ed5abeb44e21c1e13a7a57e0f02eb8a1dece6e
>        https://github.com/Hamlib/Hamlib/commit/83ed5abeb44e21c1e13a7a57e0f02eb8a1dece6e
>    Author: Daniele Forsi IU5HKX <iu...@gm...>
>    Date:   2025-08-30 (Sat, 30 Aug 2025)
>
>    Changed paths:
>      M src/amp_conf.c
>      M src/amp_reg.c
>      M src/amplifier.c
>      M src/cm108.c
>      M src/cm108.h
>      M src/conf.c
>      M src/extamp.c
>      M src/gpio.c
>      M src/iofunc.c
>      M src/mem.c
>      M src/network.c
>      M src/parallel.c
>      M src/register.c
>      M src/register.h
>      M src/rig.c
>      M src/rot_conf.c
>      M src/rot_reg.c
>      M src/rot_settings.c
>      M src/rotator.c
>      M src/serial.c
>      M src/settings.c
>      M src/snapshot_data.c
>      M src/sprintflst.c
>      M src/usb_port.c
>      M src/usb_port.h
>
>    Log Message:
>    -----------
>    [src] Remove unused includes
>
> Found by iwyu.

This removes a large part of the prep work already done for the 
refactoring of include files in 5.0.

Yes, there are some duplicate `#include`s, but one of those is 
conditional and will go away.

>
>    Commit: 47f60d4ad7e98fe9c4d2dfe46cd531f8ebf64fe3
>        https://github.com/Hamlib/Hamlib/commit/47f60d4ad7e98fe9c4d2dfe46cd531f8ebf64fe3
>    Author: Daniele Forsi IU5HKX <iu...@gm...>
>    Date:   2025-08-30 (Sat, 30 Aug 2025)
>
>    Changed paths:
>      M simulators/sim.h
>      M simulators/simeasycomm.c
>      M simulators/simelecraft.c
>      M simulators/simelecraftk4.c
>      M simulators/simft1000.c
>      M simulators/simft736.c
>      M simulators/simft747gx.c
>      M simulators/simft817.c
>      M simulators/simft847.c
>      M simulators/simft897.c
>      M simulators/simjupiter.c
>      M simulators/simrotorez.c
>      M simulators/simspid.c
>      M simulators/simtrusdx.c
>      M simulators/simts450.c
>      M simulators/simts890.c
>
>    Log Message:
>    -----------
>    [simulators] Remove unused includes
>
>      Found by iwyu.
>
>
>    Commit: d227444aa60ad7f35e204607d9506e1fab5b14bd
>        https://github.com/Hamlib/Hamlib/commit/d227444aa60ad7f35e204607d9506e1fab5b14bd
>    Author: Daniele Forsi IU5HKX <iu...@gm...>
>    Date:   2025-08-30 (Sat, 30 Aug 2025)
>
>    Changed paths:
>      M src/amp_reg.c
>      M src/rot_reg.c
>
>    Log Message:
>    -----------
>    Fix return values of amp_load_backend() and rot_load_backend()
>
> The value -EINVAL is in the domain of errno.
>
>
> Compare: https://github.com/Hamlib/Hamlib/compare/0a06af1ddef5...d227444aa60a
>
> To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications
>
>
> _______________________________________________
> Hamlib-developer mailing list
> Ham...@li...
> https://lists.sourceforge.net/lists/listinfo/hamlib-developer