[Hamlib-commits] Hamlib -- Ham radio control libraries branch Hamlib-4.6.3 updated. 4.6.4-9-g02363078f

[n0nb <n0...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Hamlib -- Ham radio control libraries".

The branch, Hamlib-4.6.3 has been updated
       via  02363078fc379b6772a9593954585f27a3518093 (commit)
       via  2de29624a0ad1a662c63fac3b6aa6733ce2da62f (commit)
       via  1b70351bf7892e34bc56b7ad1ea1b1d7ddfa4cf1 (commit)
      from  8aca7436b539406bf9df1f7543a606c73227865b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 02363078fc379b6772a9593954585f27a3518093
Author: Nate Bargmann <n0...@n0...>
Date:   Thu Aug 14 08:05:32 2025 -0500

    Update Segfault-award for rigctl fix
    
    Thanks, Daniele.

diff --git a/Segfault-award b/Segfault-award
index 69234e7f6..2081711a8 100644
--- a/Segfault-award
+++ b/Segfault-award
@@ -7,6 +7,8 @@ A developer cannot apply for HSHR for segfaults on his/her own code.
 
 Here is the list of the brave fellows:
 
+* Daniele Forsi, IU5HKX, v4.6.4, Fix segfault with set_parm KEYERTYPE.
+
 * Daniele Forsi, IU5HKX, v4.6.4, Improper indexing in netrigctl_open().
 
 * Christoph Berg DF7CB  python with Hamlib.rig_parse(None)

commit 2de29624a0ad1a662c63fac3b6aa6733ce2da62f
Author: Nate Bargmann <n0...@n0...>
Date:   Thu Aug 14 08:04:20 2025 -0500

    Update NEWS with seg fault fix in rigctl

diff --git a/NEWS b/NEWS
index 7f207bc23..65adb642d 100644
--- a/NEWS
+++ b/NEWS
@@ -20,6 +20,8 @@ Version 4.6.5
         * Update Kenwood CW buffer max message size, fix one byte buffer
           overrun in icom.c.  (TNX George Baltz).
         * Fix Segmentation Fault in rigs/dummy/netrigctl.c. (TNX Daniele Forsi)
+        * Fix segfault with set_parm KEYERTYPE in rigctl_parse.c. (TNX Daniele
+          Forsi)
 
 Version 4.6.4
         * 2025-07-18--Hamlib's 25th birthday!!!

commit 1b70351bf7892e34bc56b7ad1ea1b1d7ddfa4cf1
Author: Daniele Forsi IU5HKX <iu...@gm...>
Date:   Wed Aug 13 14:25:54 2025 +0200

    Fix segfault with set_parm KEYERTYPE
    
    Steps to reproduce:
    tests/rigctl -m 1 \
    set_parm KEYERTYPE BUG
    
    Fixes:
     Thread 1 "rigctl" received signal SIGSEGV, Segmentation fault.
     __strlen_sse2 () at ../sysdeps/x86_64/multiarch/strlen-sse2.S:142
     warning: 142    ../sysdeps/x86_64/multiarch/strlen-sse2.S: File o directory non esistente
     (gdb) bt
     #0  __strlen_sse2 () at ../sysdeps/x86_64/multiarch/strlen-sse2.S:142
     #1  0x00007ffac346e300 in __printf_buffer (buf=buf@entry=0x7ffc3bcf40d0, format=0x7ffac38aef17 "%s", ap=0x7ffc3bcf4190, mode_flags=0) at ./stdio-common/vfprintf-process-arg.c:435
     #2  0x00007ffac3491daf in __vsnprintf_internal (string=<optimized out>, maxlen=<optimized out>, format=<optimized out>, args=args@entry=0x7ffc3bcf4190, mode_flags=mode_flags@entry=0) at ./libio/vsnprintf.c:96
     #3  0x00007ffac3469642 in __GI___snprintf (s=s@entry=0x7ffc3bcf4290 "", maxlen=maxlen@entry=32, format=format@entry=0x7ffac38aef17 "%s") at ./stdio-common/snprintf.c:31
     #4  0x00007ffac370b7b9 in dummy_set_parm (rig=0x558fe1991b20, parm=2048, val=...) at dummy.c:1704
     #5  0x0000558fb536afbe in rigctl_set_parm (rig=0x558fe1991b20, fout=0x7ffac35f25c0 <_IO_2_1_stdout_>, fin=<optimized out>, interactive=<optimized out>, prompt=<optimized out>, vfo_opt=<optimized out>, send_cmd_term=13 '\r', ext_resp=0,
         resp_sep=10 '\n', cmd=0x558fb5388000 <test_list+1440>, vfo=536870912, arg1=0x7ffc3bcf4e10 "KEYERTYPE", arg2=0x558fb537fdb1 "1", arg3=0x558fb537ece8 "") at rigctl_parse.c:3829
     #6  0x0000558fb53727d6 in rigctl_parse (my_rig=<optimized out>, fin=<optimized out>, fout=<optimized out>, argv=argv@entry=0x7ffc3bcf6fd8, argc=argc@entry=3, sync_cb=sync_cb@entry=0x0, interactive=<optimized out>, prompt=<optimized out>,
         vfo_opt=<optimized out>, send_cmd_term=<optimized out>, ext_resp_ptr=<optimized out>, resp_sep_ptr=<optimized out>, use_password=<optimized out>) at rigctl_parse.c:1847
     #7  0x0000558fb535cadc in main (argc=<optimized out>, argv=0x7ffc3bcf6fd8) at rigctl.c:801
    (cherry picked from commit 12ba55834370d0b314079f6a67983c11bb26a3b9)

diff --git a/tests/rigctl_parse.c b/tests/rigctl_parse.c
index f67d7d179..79475a8ac 100644
--- a/tests/rigctl_parse.c
+++ b/tests/rigctl_parse.c
@@ -3794,11 +3794,13 @@ declare_proto_rig(set_parm)
     }
     else if (RIG_PARM_IS_STRING(parm))
     {
+#if 0
         if (parm == RIG_PARM_KEYERTYPE)
         {
             val.i = atoi(arg2);
         }
         else
+#endif
         {
             val.cs = arg2;
         }

-----------------------------------------------------------------------

Summary of changes:
 NEWS                 | 2 ++
 Segfault-award       | 2 ++
 tests/rigctl_parse.c | 2 ++
 3 files changed, 6 insertions(+)


hooks/post-receive
-- 
Hamlib -- Ham radio control libraries