[Hamlib-commits] Hamlib -- Ham radio control libraries branch Hamlib-4.6.3 updated. 4.6.4-6-g8aca7436b

[n0nb <n0...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Hamlib -- Ham radio control libraries".

The branch, Hamlib-4.6.3 has been updated
       via  8aca7436b539406bf9df1f7543a606c73227865b (commit)
       via  9141b47057e4ebf20f1f0fafd8a1f2a3cfd2ae49 (commit)
       via  f88beb1a8e2902b44da0d1f7c05083a8596c82cb (commit)
      from  2d63d05da7d80132392b25a8405844fceea4480f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8aca7436b539406bf9df1f7543a606c73227865b
Author: Nate Bargmann <n0...@n0...>
Date:   Tue Aug 12 11:57:10 2025 -0500

    Update Segfault-award for netrigctl_open() fix
    
    Congrats, Daniele!

diff --git a/Segfault-award b/Segfault-award
index e775238db..69234e7f6 100644
--- a/Segfault-award
+++ b/Segfault-award
@@ -7,6 +7,8 @@ A developer cannot apply for HSHR for segfaults on his/her own code.
 
 Here is the list of the brave fellows:
 
+* Daniele Forsi, IU5HKX, v4.6.4, Improper indexing in netrigctl_open().
+
 * Christoph Berg DF7CB  python with Hamlib.rig_parse(None)
 
 * Saku Nyland OH1KH v4.5.1, 10/2022, rigctld.c using ptt_type=RTS

commit 9141b47057e4ebf20f1f0fafd8a1f2a3cfd2ae49
Author: Nate Bargmann <n0...@n0...>
Date:   Tue Aug 12 11:56:41 2025 -0500

    Update NEWS with seg fault fix

diff --git a/NEWS b/NEWS
index 1b9c5c1e1..7f207bc23 100644
--- a/NEWS
+++ b/NEWS
@@ -19,6 +19,7 @@ Version 4.6.5
         * 2025-??-??
         * Update Kenwood CW buffer max message size, fix one byte buffer
           overrun in icom.c.  (TNX George Baltz).
+        * Fix Segmentation Fault in rigs/dummy/netrigctl.c. (TNX Daniele Forsi)
 
 Version 4.6.4
         * 2025-07-18--Hamlib's 25th birthday!!!

commit f88beb1a8e2902b44da0d1f7c05083a8596c82cb
Author: Daniele Forsi IU5HKX <iu...@gm...>
Date:   Tue Aug 12 14:01:30 2025 +0200

    Fix segfault when executing the dump_caps command
    
    Need to convert the level number 0..63 to the level bit mask.
    Steps to reproduce
    tests/rigctld -m 1 &
    tests/rigctl -m 2 dump_caps
    
    Fixes:
     Thread 1 "rigctl" received signal SIGSEGV, Segmentation fault.
     [..]
     (gdb) bt
     #0  __strlen_sse2 () at ../sysdeps/x86_64/multiarch/strlen-sse2.S:174
     #1  0x00007f532c46e300 in __printf_buffer (buf=buf@entry=0x7ffc320ad970, format=0x7f532c8aba22 "%s(%s) ", ap=0x7ffc320ada30, mode_flags=0) at ./stdio-common/vfprintf-process-arg.c:435
     #2  0x00007f532c491daf in __vsnprintf_internal (string=<optimized out>, maxlen=<optimized out>, format=<optimized out>, args=args@entry=0x7ffc320ada30, mode_flags=mode_flags@entry=0) at ./libio/vsnprintf.c:96
     #3  0x00007f532c469642 in __GI___snprintf (
         s=s@entry=0x7ffc320aec94 "BANDSELECT(00000..0.000000/0.000000) NR(0.000000..0.000000/0.000000) PBT_IN(0.000000..0.000000/0.000000) PBT_OUT(0.000000..0.000000/0.000000) CWPITCH(0..0/10) RFPOWER(0.050000..1.000000/0.001957) MICG"...,
         maxlen=maxlen@entry=3948, format=format@entry=0x7f532c8aba22 "%s(%s) ") at ./stdio-common/snprintf.c:31
     #4  0x00007f532c6dc14a in rig_sprintf_parm_gran (
         str=str@entry=0x7ffc320aec00 "ANN(0..0/0) APO(0..0/0) BACKLIGHT(0..0/0) BEEP(0..1316880384/1315832322) TIME(0..0/0) BAT(0..0/0) KEYLIGHT(0..0/0) SCREENSAVER(0..4/0) AFIF(0..0/0) BANDSELECT(00000..0.000000/0.000000) NR(0.000000..0."...,
         nlen=nlen@entry=4096, parm=9223372036854775807, gran=gran@entry=0x55f1f3cac338) at sprintflst.c:646
     #5  0x000055f1eb6cd487 in dumpstate (rig=rig@entry=0x55f1f3ca5b20, fout=fout@entry=0x7f532c5f25c0 <_IO_2_1_stdout_>) at dumpstate.c:408
     #6  0x000055f1eb6b4b81 in rigctl_dump_caps (rig=0x55f1f3ca5b20, fout=0x7f532c5f25c0 <_IO_2_1_stdout_>, fin=<optimized out>, interactive=<optimized out>, prompt=<optimized out>, vfo_opt=<optimized out>, send_cmd_term=13 '\r', ext_resp=0,
         resp_sep=10 '\n', cmd=0x55f1eb6dc0e0 <test_list+5760>, vfo=536870912, arg1=0x0, arg2=0x55f1eb6d1ce8 "", arg3=0x55f1eb6d1ce8 "") at rigctl_parse.c:4622
     #7  0x000055f1eb6c65f6 in rigctl_parse (my_rig=<optimized out>, fin=<optimized out>, fout=<optimized out>, argv=argv@entry=0x7ffc320b2138, argc=argc@entry=3, sync_cb=sync_cb@entry=0x0, interactive=<optimized out>, prompt=<optimized out>,
         vfo_opt=<optimized out>, send_cmd_term=<optimized out>, ext_resp_ptr=<optimized out>, resp_sep_ptr=<optimized out>, use_password=<optimized out>) at rigctl_parse.c:1847
     #8  0x000055f1eb6b0adc in main (argc=<optimized out>, argv=0x7ffc320b2138) at rigctl.c:801

diff --git a/rigs/dummy/netrigctl.c b/rigs/dummy/netrigctl.c
index 382f5f039..e57c3eab8 100644
--- a/rigs/dummy/netrigctl.c
+++ b/rigs/dummy/netrigctl.c
@@ -861,8 +861,9 @@ static int netrigctl_open(RIG *rig)
 
                 for (i = 0; p != NULL && i < RIG_SETTING_MAX; ++i)
                 {
-                    int level;
-                    sscanf(p, "%d", &level);
+                    int idx, level;
+                    sscanf(p, "%d", &idx);
+                    level = rig_idx2setting(idx);
 
                     rig->caps->parm_gran[i].step.s = 0;
 

-----------------------------------------------------------------------

Summary of changes:
 NEWS                   | 1 +
 Segfault-award         | 2 ++
 rigs/dummy/netrigctl.c | 5 +++--
 3 files changed, 6 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Hamlib -- Ham radio control libraries