Re: [Hamlib-developer] Hamlib 4.6.4 release

[Diane B. <db...@db...>]

On Sun, Jul 20, 2025 at 12:18:06PM -0500, Nate Bargmann wrote:
> * On 2025 19 Jul 14:30 -0500, Diane Bruce via Hamlib-developer wrote:
> > There are some libusb changes for FreeBSD
> 
> > -    printf("      bU1devExitLat:         %u\n", ss_usb_cap->bU1DevExitLat);
> > +    printf("      wU1devExitLat:         %u\n", ss_usb_cap->bU1DevExitLat);
> > +#ifdef __FreeBSD__
> > +    printf("      wU2devExitLat:         %u\n", ss_usb_cap->wU2DevExitLat);
> > +#else
> 
> When I look at this, I'm confused.
> 
> Of the first two lines the 'b' is replaced by the 'w' in the in the
> printed string, but is left pointing to ss_usb_cap->bU1DevExitLat.
> Should the pointer or the string be changed, or neither, or both?

Mea culpa. I goofed. 
See first patch attached. Simple typo. I think I got the white space fixed
too.

A better patch (much simpler) is also attached.
see better_patch-tests_rigtestlibusb.c

Same comments apply but keep in mind FreeBSD will eventually have the 
less verbose bNumDeviceCaps instead of bNumDeviceCapabilities
The other changes are (hopefully) to be upstreamed renaming
bU2devExitLat to wU2devExitLat

FreeBSD in the head of the tree
has
/usr/include/libusb20_desc.h:#define bNumDeviceCapabilities bNumDeviceCapsa

So we have backward compatibility for this. I'd go with the
better_patch-tests_rigtestlibusb.c myself. 


Anyway both versions compiled and tested and the second better version
works with current FreeBSD tree.


> -- 
> "The optimist proclaims that we live in the best of all
> possible worlds.  The pessimist fears this is true."
> Web: https://www.n0nb.us
> Projects: https://github.com/N0NB
> GPG fingerprint: 82D6 4F6B 0E67 CD41 F689 BBA6 FB2C 5130 D55A 8819
> 

Sorry about the noise previously, I was hot and tired trying to get this into
the tree and working too fast.

Cheers!

- 73 Diane VA3DB
-- 
db...@Fr... db...@db... http://www.db.net/~db https://ottawa.place/@Dianora