Re: [Hamlib-developer] [Hamlib/Hamlib] ae9556: Fix debug messages shown even from disabled levels

[George B. <geo...@gm...>]

The code removed by this change was working exactly as designed (and 
desired).  It allowed someone to run with debug level set low (ERR or 
WARN) but still get needed info if an error occurred. Having this info 
(without wading through megabytes of other messages) is essential for 
debugging transient or hard-to-reproduce errors.

I think this commit should be reverted.

On 6/7/25 8:31 AM, dforsi via Hamlib-developer wrote:
>    Branch: refs/heads/master
>    Home:   https://github.com/Hamlib/Hamlib
>    Commit: ae9556462a2989b8b97af0d6e320558ffa0e1f3e
>        https://github.com/Hamlib/Hamlib/commit/ae9556462a2989b8b97af0d6e320558ffa0e1f3e
>    Author: Daniele Forsi IU5HKX <iu...@gm...>
>    Date:   2025-06-07 (Sat, 07 Jun 2025)
>
>    Changed paths:
>      M include/hamlib/rig.h
>      M src/debug.c
>
>    Log Message:
>    -----------
>    Fix debug messages shown even from disabled levels
>
> Messages from ENTERFUNC and RETURNFUNC where stored in an internal buffer
> even whe debug_level wasn't TRACE and were returned when calling rigerror().
>
>
>
> To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications
>
>
> _______________________________________________
> Hamlib-developer mailing list
> Ham...@li...
> https://lists.sourceforge.net/lists/listinfo/hamlib-developer