[Hamlib-developer] [Hamlib/Hamlib] c9161e: Improve error handling for GUOHETEC drivers to enh...
Library to control radio transceivers and receivers
Brought to you by:
n0nb
Menu
▾
▴
[Hamlib-developer] [Hamlib/Hamlib] c9161e: Improve error handling for GUOHETEC drivers to enh...
|
From: FVsonar <no...@gi...> - 2025-06-30 12:37:47
|
Branch: refs/heads/master Home: https://github.com/Hamlib/Hamlib Commit: c9161e2e25d80609d5127ca0c1ebe8e78cb00040 https://github.com/Hamlib/Hamlib/commit/c9161e2e25d80609d5127ca0c1ebe8e78cb00040 Author: 声纳 <159...@qq...> Date: 2025-06-28 (Sat, 28 Jun 2025) Changed paths: M rigs/guohetec/guohetec.c M rigs/guohetec/guohetec.h M rigs/guohetec/pmr171.c M rigs/guohetec/q900.c Log Message: ----------- Improve error handling for GUOHETEC drivers to enhance WSJT-X compatibility - Add graceful degradation for communication errors - Return cached values instead of error codes on failures - Implement unified response validation functions - Add cache return macros for consistent error handling - Maintain backward compatibility while improving stability This change ensures WSJT-X and similar applications continue working even when temporary communication issues occur with GUOHETEC radios. Fixes: WSJT-X compatibility issues with PMR-171 and Q900 drivers Commit: abf6be0b5e80b3d2376ac873ccf2602ad8e8199f https://github.com/Hamlib/Hamlib/commit/abf6be0b5e80b3d2376ac873ccf2602ad8e8199f Author: 声纳 <159...@qq...> Date: 2025-06-28 (Sat, 28 Jun 2025) Changed paths: M rigs/guohetec/guohetec.c M rigs/guohetec/pmr171.c Log Message: ----------- Fix compilation errors in GUOHETEC drivers - Remove duplicate function declarations in pmr171_send - Remove duplicate code blocks in pmr171_set_mode - Remove duplicate pmr171_send calls in pmr171_set_ptt - Add missing from_be function implementation - Fix syntax errors that were causing CI failures Commit: dee29c555f98413486dd7110b601aa403035970d https://github.com/Hamlib/Hamlib/commit/dee29c555f98413486dd7110b601aa403035970d Author: 声纳 <159...@qq...> Date: 2025-06-28 (Sat, 28 Jun 2025) Changed paths: M rigs/guohetec/pmr171.c M rigs/guohetec/q900.c Log Message: ----------- Implement consistent error handling for GUOHETEC drivers - Use unified error handling mechanism in send_cmd2 functions - Always return RIG_OK to prevent WSJT-X errors - Update cache with requested values even when communication fails - Use English comments and debug messages - Ensure graceful degradation with cached values on protocol/timeout errors Commit: 19c2cc03156846d22262536e9cde7f70deff26db https://github.com/Hamlib/Hamlib/commit/19c2cc03156846d22262536e9cde7f70deff26db Author: 声纳 <159...@qq...> Date: 2025-06-28 (Sat, 28 Jun 2025) Changed paths: M rigs/guohetec/guohetec.c Log Message: ----------- Fix duplicate retval variable definition in guohetec.c probe function Commit: a61877a60be23df45439cc607585ecfe55d46395 https://github.com/Hamlib/Hamlib/commit/a61877a60be23df45439cc607585ecfe55d46395 Author: 声纳 <159...@qq...> Date: 2025-06-28 (Sat, 28 Jun 2025) Changed paths: M rigs/guohetec/pmr171.c M rigs/guohetec/q900.c Log Message: ----------- Fix duplicate stdint.h includes in pmr171.c and q900.c Commit: c2d4fbe601c7d6dce463d133634c2458e0489fd3 https://github.com/Hamlib/Hamlib/commit/c2d4fbe601c7d6dce463d133634c2458e0489fd3 Author: 声纳 <159...@qq...> Date: 2025-06-28 (Sat, 28 Jun 2025) Changed paths: M rigs/guohetec/guohetec.c M rigs/guohetec/guohetec.h M rigs/guohetec/pmr171.c M rigs/guohetec/q900.c Log Message: ----------- guohetec: comprehensive code quality improvements - Fix compilation warnings by removing unnecessary dump_hex function calls - Resolve implicit function declaration warnings for validation macros - Remove duplicate GUOHE_MODE_TABLE_MAX definitions across files - Optimize header includes based on IWYU suggestions: * Add iofunc.h (for read_block/write_block functions) * Add riglist.h (for RIG_MODEL_* constants) * Remove unistd.h, misc.h, serial.h (unnecessary includes) - Convert validation macros to functions for better compiler compatibility - Maintain backward compatibility with existing macro definitions - Improve code structure and maintainability - Ensure WSJT-X compatibility with consistent error handling All changes maintain existing functionality while improving code quality and reducing compilation warnings. Commit: 6797ab7646030b93ebffdcb57e8583928d106a5f https://github.com/Hamlib/Hamlib/commit/6797ab7646030b93ebffdcb57e8583928d106a5f Author: 声纳 <159...@qq...> Date: 2025-06-28 (Sat, 28 Jun 2025) Changed paths: M rigs/guohetec/guohetec.c M rigs/guohetec/guohetec.h M rigs/guohetec/pmr171.c M rigs/guohetec/q900.c Log Message: ----------- guohetec: fix cppcheck warnings and improve code quality Based on cppcheck analysis and maintainer feedback: - Fix constParameterPointer warnings: declare reply parameters as const where appropriate - Fix variableScope warnings: reduce reply variable scope to minimum required - Apply IWYU (IncludeWhatYouUse) suggestions for header optimization: * Add iofunc.h (for read_block, write_block functions) * Add riglist.h (for RIG_MODEL_* constants) * Remove unistd.h, misc.h, serial.h (unnecessary includes) - Maintain backward compatibility and existing functionality - Improve code maintainability and reduce compilation warnings All changes follow maintainer recommendations and maintain WSJT-X compatibility. Commit: b95d349bff845a6cc936f838087fdce62aa7194d https://github.com/Hamlib/Hamlib/commit/b95d349bff845a6cc936f838087fdce62aa7194d Author: 声纳 <159...@qq...> Date: 2025-06-30 (Mon, 30 Jun 2025) Changed paths: M rigs/guohetec/guohetec.c M rigs/guohetec/guohetec.h M rigs/guohetec/pmr171.c M rigs/guohetec/q900.c Log Message: ----------- Add LGPLv2.1 license headers to GUOHETEC driver files Commit: a6fb8a079a562014b9948e16a2dd817346fcf4e2 https://github.com/Hamlib/Hamlib/commit/a6fb8a079a562014b9948e16a2dd817346fcf4e2 Author: 声纳 <159...@qq...> Date: 2025-06-30 (Mon, 30 Jun 2025) Changed paths: M rigs/guohetec/guohetec.c M rigs/guohetec/guohetec.h M rigs/guohetec/pmr171.c M rigs/guohetec/q900.c Log Message: ----------- Update copyright to GUOHETEC in license headers for all GUOHETEC driver files Compare: https://github.com/Hamlib/Hamlib/compare/862fda58be87...a6fb8a079a56 To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications |
