[Hamlib-developer] [Hamlib/Hamlib] 72bde6: Fix sign of error return values

[Nate B. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/Hamlib/Hamlib
  Commit: 72bde6e13171e1c2425e094413598ec88a8397a0
      https://github.com/Hamlib/Hamlib/commit/72bde6e13171e1c2425e094413598ec88a8397a0
  Author: Daniele Forsi IU5HKX <iu...@gm...>
  Date:   2025-06-07 (Sat, 07 Jun 2025)

  Changed paths:
    M include/hamlib/rig.h
    M tests/rigctl.c
    M tests/rigctld.c
    M tests/rigctltcp.c

  Log Message:
  -----------
  Fix sign of error return values

All RIG_E* constants should be negated when returned or compared.
Change the usages of RIG_IS_SOFT_ERRCODE() for consistency.


  Commit: 721b81d9bed4c23ce74d1140833968c55e6b4d1e
      https://github.com/Hamlib/Hamlib/commit/721b81d9bed4c23ce74d1140833968c55e6b4d1e
  Author: Daniele Forsi IU5HKX <iu...@gm...>
  Date:   2025-06-07 (Sat, 07 Jun 2025)

  Changed paths:
    M src/amp_conf.c
    M src/amplifier.c
    M src/cm108.c
    M src/event.c
    M src/extamp.c
    M src/locator.c
    M src/rig.c
    M src/rot_conf.c
    M src/rot_ext.c
    M src/rot_settings.c
    M src/rotator.c

  Log Message:
  -----------
  Fix sign of return values Doxygen comments

All RIG_E* constants are negated when returned.

Fied with:
perl -pe 's/return RIG_E/return -RIG_E/' -i src/vent.c
perl -pe 's/retval RIG_E/retval -RIG_E/g' -i $(grep -lEr "retval RIG_E" --include=*.{c,h})


  Commit: 10180a6dc2433d525d4c3ba75c2f6519f0c55031
      https://github.com/Hamlib/Hamlib/commit/10180a6dc2433d525d4c3ba75c2f6519f0c55031
  Author: Daniele Forsi IU5HKX <iu...@gm...>
  Date:   2025-06-07 (Sat, 07 Jun 2025)

  Changed paths:
    M rigs/adat/adat.c
    M rigs/dummy/flrig.c
    M rigs/dummy/quisk.c
    M rigs/icom/icom.c
    M rigs/kenwood/ic10.c
    M rigs/kenwood/k3.c
    M rigs/pcr/pcr.c
    M rigs/tentec/orion.c
    M rigs/yaesu/ft757gx.c
    M rotators/grbltrk/grbltrk.c
    M rotators/meade/meade.c
    M rotators/skywatcher/skywatcher.c
    M src/rig.c
    M tests/ampctl_parse.c
    M tests/rigmem.c
    M tests/rigsmtr.c
    M tests/rigswr.c
    M tests/rotctl_parse.c

  Log Message:
  -----------
  Fix sign of error return values

All RIG_E* constants should be negated when returned or compared.

Fixed with:
perl -pe 's/return RIG_E/return -RIG_E/' -i $(grep -lEr "return RIG_E" --include=*.{c,h})
perl -pe 's/= RIG_E/= -RIG_E/g' -i $(grep -lEr "= RIG_E" --include=*.{c,h})


  Commit: 7b60cb586dc6b1f76bd85bceba42dac373159914
      https://github.com/Hamlib/Hamlib/commit/7b60cb586dc6b1f76bd85bceba42dac373159914
  Author: Nate Bargmann <n0...@n0...>
  Date:   2025-06-07 (Sat, 07 Jun 2025)

  Changed paths:
    M include/hamlib/rig.h
    M rigs/adat/adat.c
    M rigs/dummy/flrig.c
    M rigs/dummy/quisk.c
    M rigs/icom/icom.c
    M rigs/kenwood/ic10.c
    M rigs/kenwood/k3.c
    M rigs/pcr/pcr.c
    M rigs/tentec/orion.c
    M rigs/yaesu/ft757gx.c
    M rotators/grbltrk/grbltrk.c
    M rotators/meade/meade.c
    M rotators/skywatcher/skywatcher.c
    M src/amp_conf.c
    M src/amplifier.c
    M src/cm108.c
    M src/event.c
    M src/extamp.c
    M src/locator.c
    M src/rig.c
    M src/rot_conf.c
    M src/rot_ext.c
    M src/rot_settings.c
    M src/rotator.c
    M tests/ampctl_parse.c
    M tests/rigctl.c
    M tests/rigctld.c
    M tests/rigctltcp.c
    M tests/rigmem.c
    M tests/rigsmtr.c
    M tests/rigswr.c
    M tests/rotctl_parse.c

  Log Message:
  -----------
  Merge GitHub PR #1751


Compare: https://github.com/Hamlib/Hamlib/compare/ae9556462a29...7b60cb586dc6

To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications