Re: [Hamlib-developer] [Hamlib/Hamlib] c8838c: Avoid truncating AC Log frequencies above 1 GHz

[George B. <geo...@gm...>]

Maybe I'm missing something, but did anybody ask the upstream why they 
were adding human-oriented punctuation to a computer-to-computer 
communication?  Formatting should almost always be done at the final 
user interface, to allow for locality based display.


On 5/1/25 9:48 PM, Nate Bargmann via Hamlib-developer wrote:
>    Branch: refs/heads/master
>    Home:   https://github.com/Hamlib/Hamlib
>    Commit: c8838cd3a6f4ea57ccbde8cb646c5a4fbfd82a3e
>        https://github.com/Hamlib/Hamlib/commit/c8838cd3a6f4ea57ccbde8cb646c5a4fbfd82a3e
>    Author: Nate Bargmann <n0...@n0...>
>    Date:   2025-05-01 (Thu, 01 May 2025)
>
>    Changed paths:
>      M rigs/dummy/aclog.c
>
>    Log Message:
>    -----------
>    Avoid truncating AC Log frequencies above 1 GHz
>
> Per GitHub issue #1704, frequencies higher than 1 GHz passed from AC Log
> have an embedded comma.  Even though sscanf() offers the "'" (single
> quote) character as a means of ignoring thousands separator, apparently
> it depends on the environment variable LC_NUMERIC being set correctly
> and that may not be supported on all platforms.
>
> This patch just parses through the string while skipping any comma that
> may appear and then uses strtold() to convert to a numeric variable.  It
> is supected that AC Log always uses a comma as a thousands separator.
>
>
>    Commit: fe3bb8b84a47ec4e928e65fc5a9a104b89747162
>        https://github.com/Hamlib/Hamlib/commit/fe3bb8b84a47ec4e928e65fc5a9a104b89747162
>    Author: Nate Bargmann <n0...@n0...>
>    Date:   2025-05-01 (Thu, 01 May 2025)
>
>    Changed paths:
>      M rigs/dummy/aclog.c
>
>    Log Message:
>    -----------
>    Merge pull request #1722 from N0NB/aclog_get_freq-thousands_separator
>
> Avoid truncating AC Log frequencies above 1 GHz
>
>
> Compare: https://github.com/Hamlib/Hamlib/compare/12265fde9ad3...fe3bb8b84a47
>
> To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications
>
>
> _______________________________________________
> Hamlib-developer mailing list
> Ham...@li...
> https://lists.sourceforge.net/lists/listinfo/hamlib-developer