Re: [Hamlib-developer] [Hamlib/Hamlib] 5219ef: Put a heavier LOCK around send_morse when clearing...

[Black M. <mdb...@ya...>]

You're right -- I need to force the lock in this case -- the LOCK() macro was just for the top thread.

Just put in a patch to do that.

Mike W9MDB








On Monday, December 2, 2024 at 03:44:36 AM CST, George Baltz <geo...@gm...> wrote: 





I'll give it a try, but I don't think it'll make a difference. LOCK() 
depends on rs->depth, which morse_data_handler() has no control over.  
Most times it will be a NOP(depth==0), but worse is if some other thread 
changes depth while it is running; then LOCK has different actions at 
beginning and end of loop.

On 12/1/24 11:41 PM, Michael Black via Hamlib-developer wrote:
>    Branch: refs/heads/master
>    Home:  https://github.com/Hamlib/Hamlib
>    Commit: 5219ef2b26fa657e9370fefbdfa6396ecda7faa3
>        https://github.com/Hamlib/Hamlib/commit/5219ef2b26fa657e9370fefbdfa6396ecda7faa3
>    Author: Michael Black W9MDB <mdb...@ya...>
>    Date:  2024-12-01 (Sun, 01 Dec 2024)
>
>    Changed paths:
>      M src/rig.c
>
>    Log Message:
>    -----------
>    Put a heavier LOCK around send_morse when clearing the buffer
>
>
>    Commit: 711a35135326af3f949bd69b227bd3e31d67c6ae
>        https://github.com/Hamlib/Hamlib/commit/711a35135326af3f949bd69b227bd3e31d67c6ae
>    Author: Michael Black W9MDB <mdb...@ya...>
>    Date:  2024-12-01 (Sun, 01 Dec 2024)
>
>    Changed paths:
>      M NEWS
>      M bindings/csharp/multicast/README.txt
>      M rigs/icom/ic821h.c
>      M rigs/kenwood/thf6a.c
>      M rigs/kenwood/ts590.c
>      M rigs/yaesu/README.ft920
>      M rotators/easycomm/easycomm.txt
>      M simulators/simts890.c
>      M src/microham.c
>      M src/rig.c
>      M src/sleep.c
>
>    Log Message:
>    -----------
>    Merge branch 'master' of github.com:Hamlib/Hamlib
>
>
> Compare: https://github.com/Hamlib/Hamlib/compare/7b679afa1d85...711a35135326
>
> To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications
>
>
> _______________________________________________
> Hamlib-developer mailing list
> Ham...@li...
> https://lists.sourceforge.net/lists/listinfo/hamlib-developer



_______________________________________________
Hamlib-developer mailing list
Ham...@li...
https://lists.sourceforge.net/lists/listinfo/hamlib-developer