Re: [Hamlib-developer] [Hamlib/Hamlib] ecadc4: Fix IC756 warnings for MacOS

[George B. <geo...@gm...>]

On 9/10/24 11:13 PM, Black Michael wrote:
> Sorry you think it's a waste of time to clear up compiler warnings.  I disagree.
>
I have no problem clearing up compiler warnings if

- They address real problems

- They make my life simpler, as programmer or maintainer

- They reduce the probability of future problems

These changes don't seem to help any of those.


1) The warning is bogus.  Setting a baseline or default for any value 
and then overriding that in specific or localized instances is a pretty 
fundamental way we build, configure or execute programs.  Do you get a 
warning for adding a CLI option to override a program default? Or when a 
.rc file changes a default to what >you< want?  Do you have to rebuild a 
program, removing the default before adding your own choice?  I don't 
think so.  Stigmatizing that hierarchy of settings doesn't seem like a 
good idea to me.

2) So far it's taken about 400 lines of code(LoC). That's 400 more to 
maintain. And it changes simple one-liners into changes in multiple 
places, possibly multiple files. Simplify, simplify.

3) It makes the code much more fragile; instead of making a data change 
in one place, you need to sync three.  And there's no default to fall 
back on, just by removing the override. Again, multiple actions instead 
of one.


Sorry, but this doesn't look like progress to me.  YMMV.


73

n3gb