Re: [Hamlib-developer] Spid rotator crash

[Black M. <mdb...@ya...>]

priv should never be null unless you are calling these functions directly instead of going through the API.
But I added the patch anyways.
Mike W9MDB

 

    On Thursday, August 15, 2024 at 12:58:54 PM CDT, G0GJV <g0...@go...> wrote:  
 
 I've found that very recently my rotator control code is crashing when 
I tell a Spid Rot1Prog controller to "stop".

Building a debug version of Hamlib on a Mac has isolated this to line 
538 of spid.c

priv->dir = 0;

This is because "priv" is only going to be valid for a Rot2Prog (az/el) 
controller'

My "simple" (and working) fix is just

    if (priv)
    { 
        priv->dir = 0;
    }
    
I think this is the only place this mistake has been made; I'd offer a 
patch, but I'm not confident without some background as to why this 
code was fairly recently added.

Mike G0GJV




_______________________________________________
Hamlib-developer mailing list
Ham...@li...
https://lists.sourceforge.net/lists/listinfo/hamlib-developer