Re: [Hamlib-developer] [Hamlib/Hamlib] 1557ad: Fix rotorez set_conf in both rotctl and rotctld --...

[George B. <geo...@gm...>]

This is a really bad way to attack the problem - it doesn't fix it for 
the general application interface, as it changes the wrong side of the 
API.  Every other device Hamlib supports allows config changes between 
'my_<whatever> = <whatever>_init(model)' and 
'<whatever>_open(my_<whatever>,...)'.  So the error is not in rotctl or 
rotctld, but in rotorez.c.  It needs to be fixed to save the state of 
any config changes and make sure they are in effect before the device is 
declared usable, i.e., when rot_open() returns.

On 6/7/24 5:08 PM, Michael Black via Hamlib-developer wrote:
>    Branch: refs/heads/master
>    Home:   https://github.com/Hamlib/Hamlib
>    Commit: 1557ad70f752f7217c1eff963af1a1f3c4f96026
>        https://github.com/Hamlib/Hamlib/commit/1557ad70f752f7217c1eff963af1a1f3c4f96026
>    Author: Mike Black W9MDB <mdb...@ya...>
>    Date:   2024-06-07 (Fri, 07 Jun 2024)
>
>    Changed paths:
>      M tests/rotctl.c
>      M tests/rotctld.c
>
>    Log Message:
>    -----------
>    Fix rotorez set_conf in both rotctl and rotctld -- since it needs to be done after rot_open
>
>
>
> To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications
>
>
> _______________________________________________
> Hamlib-developer mailing list
> Ham...@li...
> https://lists.sourceforge.net/lists/listinfo/hamlib-developer