Re: [Hamlib-developer] [Hamlib/Hamlib] cf91e9: Refactoring GPIO push-to-talk logic to use libgpio...

[George B. <geo...@gm...>]

This breaks things very badly.  Adding the gpio pointer into the middle 
of the hamlib_port_t structure means all the offsets are different from 
what are compiled into the apps;  i.e., it breaks API compatibility.  
Tried with wsjt-x, and again no transmit.


On 5/12/24 12:41 PM, Michael Black via Hamlib-developer wrote:
>    Branch: refs/heads/master
>    Home:   https://github.com/Hamlib/Hamlib
>    Commit: cf91e96333979368a0bde89d5c31b7ed4f39bce5
>        https://github.com/Hamlib/Hamlib/commit/cf91e96333979368a0bde89d5c31b7ed4f39bce5
>    Author: Addison Schuhardt <ad...@sc...>
>    Date:   2024-04-11 (Thu, 11 Apr 2024)
>
>    Changed paths:
>      M configure.ac
>      M include/hamlib/rig.h
>      M src/gpio.c
>
>    Log Message:
>    -----------
>    Refactoring GPIO push-to-talk logic to use libgpiod rather than the deprecated/broken sysfs method.
> TODO: I'm not familiar with autoconf to set up linking to libgpiod correctly, so I'd like to ask someone else to do that.
> Fixes #1538
>
>
>    Commit: c06255d364574b312858200fd11d3710708edf5b
>        https://github.com/Hamlib/Hamlib/commit/c06255d364574b312858200fd11d3710708edf5b
>    Author: Michael Black <mdb...@ya...>
>    Date:   2024-05-12 (Sun, 12 May 2024)
>
>    Changed paths:
>      M configure.ac
>      M include/hamlib/rig.h
>      M src/gpio.c
>
>    Log Message:
>    -----------
>    Merge pull request #1539 from aschuhardt/libgpiod
>
> Refactoring GPIO push-to-talk logic to use libgpiod rather than the d…
>
>
> Compare: https://github.com/Hamlib/Hamlib/compare/1988b7cf4fa9...c06255d36457
>
> To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications
>
>
> _______________________________________________
> Hamlib-developer mailing list
> Ham...@li...
> https://lists.sourceforge.net/lists/listinfo/hamlib-developer