Re: [Hamlib-developer] AOR AR5000

[Chuck H. <n2...@am...>]

On 24-Feb-03 Stephane Fillod wrote:
> I wrote initial support for the AOR backend, but it has never been
> tested to a point where at least one command works :)
> So the "\r" patch is applied.

Looking at your patch, I noticed one thing that was different from mine:
The reason I didn't change EOM was I didn't change EOM in aor_transaction.
From the docs and the fact that it didn't stair step in kermit (sorry, I didn't
look that closely at the hamlib debug dump) I assume that the radio responds
with the result line followed by a CR LF.  I don't know what the effect would
be if it stops reading at the CR.  Would it help to have a radio->hamlib
returned EOM set to CR LF?

I'll be happy to test it the next time I get a chance, but it will probably be
a few weeks.  First, I have to fix the bugs in my code that I found, and then I
have to get up there, and get a chance to play with his radios.

> 
>> I also ran across a bug where in aor_get_freq if the response from the radio
>> didn't have a "RF" in it (eg. because of a timeout) then it would try to do
>> a
>> scanf with a null pointer and segfault.
> 
> Ahah! still on the "Segfault-award" quest ;-)
> patch applied.

I didn't mean to. :)
It was just one of those little tested code paths.  Since the radio didn't
understand the command, it was timing out.  So the buffer was empty.  By
definition empty buffers don't have an "RF" in them.  :)

> Absolutely. To give you a quick start, I've commited an initial
> get_levl/set_level support. There's no guarantee it will work!

Thanks.  Now I have to add support to my code for it.
I wouldn't have worried about it right now except that the radio locks the
keyboard (but not the tuning knob) when the computer is talking to it.  So you
can't just push the button.
And with a noisy down converter before the radio the attenuator helps.

Thanks for all your help with hamlib.  Otherwise I would have to write drivers
for all the radios I get a chance to play with.  Now all I have to worry about
is all the different quirks that the radios have. :)
Maybe when I get a chance I'll write up something about the things I've found.