Re: [Hamlib-developer] AOR AR5000

[Stephane F. <f8...@fr...>]

Hi Chuck, good to see you again!

On Mon, Feb 24, 2003, Chuck Hemker wrote:
> I had a chance to play a little bit with an AOR AR5000 the other day.
> I ran into a problem with hamlib in that the radio expects sent to it to be
> terminated by a CR.  In aor.c, the commands being sent are terminated with a
> EOM, which translates to "0xa" which translates to LF.
> 
> I'm not sure if anyone has tested this yet or if any of the AOR radios expect
> commands to be terminated with a LF.  If there are, it's going to make the
> patch a little more difficult.

I wrote initial support for the AOR backend, but it has never been
tested to a point where at least one command works :)
So the "\r" patch is applied.

> I also ran across a bug where in aor_get_freq if the response from the radio
> didn't have a "RF" in it (eg. because of a timeout) then it would try to do a
> scanf with a null pointer and segfault.

Ahah! still on the "Segfault-award" quest ;-)
patch applied.

> I didn't have a lot of time while I was playing with the radio, so I didn't
> have a chance to test most of the functions.  And I didn't have time to make
> the changes look nice.  I attached an example of the quick changes I did, and
> with them, get_freq and set_freq seemed to work fine.  If you want, I'll try to
> come up with a cleaner patch.

That's fine, it was short and obvious.

> By the way, I need to be able to set the radio's attenuator using hamlib and I
> didn't see any support for the in aor.c.  Does that just require creating a
> aor_set_level that does the work, and adding it to the cap structure in
> AR5000.c?

Absolutely. To give you a quick start, I've commited an initial
get_levl/set_level support. There's no guarantee it will work!

BTW, I've fixed the set_mode/get_mode. Passband width is missing though.


Thanks for the testing.

Cheers,
Stephane